Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for azurerm_eventhub_namespace_authorization_rule #3577

Closed
alastairtree opened this issue Jun 3, 2019 · 4 comments · Fixed by #5489
Closed

Add data source for azurerm_eventhub_namespace_authorization_rule #3577

alastairtree opened this issue Jun 3, 2019 · 4 comments · Fixed by #5489

Comments

@alastairtree
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Summary

Please add a new data source for an existing event hub namespace auth rule, in addition to the existing resource that creates authorisation rule resources.

Motivation

If using event hubs for diagnostic logging then many resources will need auth rule keys to be able send logs to the hub. Event hubs are limited to 12 auth rules, so an auth rule needs to be reused across many resources diagnostic settings. When using the azurerm_monitor_diagnostic_setting we need to pass the ID of the event hub auth rule in the eventhub_authorization_rule_id argument, and there is no way to acquire the ID of the rule without creating it in the same template or string building based on the eventhub namespace datasource.

New or Affected Resource(s)

  • azurerm_eventhub_namespace_authorization_rule

Potential Terraform Configuration

data "azurerm_eventhub_namespace_authorization_rule" "test" {
  name                           = "test-rule"
  namespace_name        = "eventhub-ns"
  resource_group_name = "eventhug-rg"
}
@katbyte

This comment has been minimized.

@katbyte katbyte closed this as completed Oct 29, 2019
@katbyte katbyte added this to the v1.36.0 milestone Oct 29, 2019
@alastairtree
Copy link
Contributor Author

@katbyte I don't think that #4615 contains any related changes? Should this be reopened?

@ghost
Copy link

ghost commented Nov 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 29, 2019
@katbyte
Copy link
Collaborator

katbyte commented Dec 31, 2019

@alastairtree, you are correct! Seems i commented and closed on the wrong issue. Reopened

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants