Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate contents and password as sensitive #3064

Merged

Conversation

Lucretius
Copy link
Contributor

Resolves #3056

I also marked the certificate password as sensitive.

@Lucretius
Copy link
Contributor Author

Not sure why the lint check is failing - I ran the same command locally without issue. Unit tests passed, and I was able to run the compiled binary against some sample resources to verify the intended behavior. Any ideas what could be causing the failure?

@tombuildsstuff
Copy link
Contributor

@Lucretius it appears the hosted linter we use has added a new linter overnight, which is why this is failing - I'll open a separate PR to fix those; sorry about that.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @Lucretius

@tombuildsstuff tombuildsstuff added this to the v1.24.0 milestone Mar 18, 2019
@tombuildsstuff
Copy link
Contributor

There's a PR open for the linting fixes in #3065 - since this is unrelated to those fixes I'm going to merge this anyway; thanks again @Lucretius :)

@tombuildsstuff tombuildsstuff merged commit 5b68747 into hashicorp:master Mar 18, 2019
tombuildsstuff added a commit that referenced this pull request Mar 18, 2019
@Lucretius Lucretius deleted the key_vault_certificate_sensitive branch March 18, 2019 08:05
@TraGicCode
Copy link

Thanks guys this was quick!

How often does this provider release?

@katbyte
Copy link
Collaborator

katbyte commented Mar 21, 2019

@TraGicCode,

we aim for bi weekly releases, however it can be as quick as 1 week and as long as 4 depending on circumstances.

@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault_certificate: Ensure certificate contents are sensitive in apply output
4 participants