-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certificate contents and password as sensitive #3064
certificate contents and password as sensitive #3064
Conversation
Not sure why the lint check is failing - I ran the same command locally without issue. Unit tests passed, and I was able to run the compiled binary against some sample resources to verify the intended behavior. Any ideas what could be causing the failure? |
@Lucretius it appears the hosted linter we use has added a new linter overnight, which is why this is failing - I'll open a separate PR to fix those; sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @Lucretius
There's a PR open for the linting fixes in #3065 - since this is unrelated to those fixes I'm going to merge this anyway; thanks again @Lucretius :) |
Thanks guys this was quick! How often does this provider release? |
we aim for bi weekly releases, however it can be as quick as 1 week and as long as 4 depending on circumstances. |
This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.24.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Resolves #3056
I also marked the certificate password as sensitive.