Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_certificate: Ensure certificate contents are sensitive in apply output #3056

Closed
TraGicCode opened this issue Mar 15, 2019 · 2 comments · Fixed by #3064
Closed
Labels
Milestone

Comments

@TraGicCode
Copy link

TraGicCode commented Mar 15, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When utilizing the azurerm_key_vault_certificate resource it exposes the certificate contents in the output when doing a terraform apply. It would be nice to have them output as since the contents are considered secrets.

Terraform Resource Example

Resources

resource "azurerm_key_vault_certificate" "test" {
  name     = "imported-cert"
  key_vault_id = "XXXXXXX"

  certificate {
    contents = "${acme_certificate.certificate.certificate_p12}"
    password = ""
  }

  certificate_policy {
    issuer_parameters {
      name = "Self"
    }

    key_properties {
      exportable = true
      key_size   = 2048
      key_type   = "RSA"
      reuse_key  = false
    }

    secret_properties {
      content_type = "application/x-pkcs12"
    }
  }
}

Apply output

azurerm_key_vault_certificate.test: Creating...
  certificate.#:                                         "" => "1"
  certificate.0.contents:                                "" => "MIIQYwI.....DU4hQwKzAfMAcGBSsOAwIaBBSg+IQFcUBiQd0B9CCQI2ozFTRg7gQI07VOA3wfLIQ="
  certificate_data:                                      "" => "<computed>"
  certificate_policy.#:                                  "" => "1"
  certificate_policy.0.issuer_parameters.#:              "" => "1"
  certificate_policy.0.issuer_parameters.0.name:         "" => "Self"
  certificate_policy.0.key_properties.#:                 "" => "1"
  certificate_policy.0.key_properties.0.exportable:      "" => "true"
  certificate_policy.0.key_properties.0.key_size:        "" => "2048"
  certificate_policy.0.key_properties.0.key_type:        "" => "RSA"
  certificate_policy.0.key_properties.0.reuse_key:       "" => "false"
  certificate_policy.0.secret_properties.#:              "" => "1"
  certificate_policy.0.secret_properties.0.content_type: "" => "application/x-pkcs12"
  certificate_policy.0.x509_certificate_properties.#:    "" => "<computed>"
  key_vault_id:                                          "" => "XXXXXX"
  name:                                                  "" => "imported-cert"
  secret_id:                                             "" => "<computed>"
  tags.%:                                                "" => "<computed>"
  thumbprint:                                            "" => "<computed>"
  vault_uri:                                             "" => "<computed>"
  version:                                               "" => "<computed>"

The certificate contents, as shown above, should be shown as sensitive in the output like below

"<sensitive>" => "<sensitive>"
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants