-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Renaming/Duplication: azurerm_monitor_autoscale_setting
/ azurerm_log_analytics_linked_service
#2768
Conversation
This is a direct copy of the `azurerm_autoscale_setting` resource which allows us to deprecate the old one Including a guide on how to migrate from one resource to the other
…d` field in the block in favour of the top level field
…_service` resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tombuildsstuff Thanks for the effort to rename the resources.
I did a quick look through the PR.
The only difference between resourceArmAutoScaleSetting
and resourceArmMonitorAutoScaleSetting
is the extra deprecate message. Maybe we can just refactor resourceArmAutoScaleSetting
a bit to support renaming scenario considering that the internal schema and functionality between these 2 functions are exactly the same ? Just my 2 cents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from a couple comments LGTM @tombuildsstuff 👍
@@ -146,6 +146,7 @@ func resourceArmNetworkInterface() *schema.Resource { | |||
Set: schema.HashString, | |||
}, | |||
|
|||
// TODO: does this want deprecating & a virtual resource for 2.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through all the changes, mostly LGTM and ready to be merged if we can address the comments in line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the suggestions in line.
dismissing since changes have been pushed
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR spans a few different areas, as a result of passing through the entire codebase looking for deprecations:
azurerm_monitor_autoscale_setting
to replace theazurerm_autoscale_setting
resource.azurerm_log_analytics_linked_service
to replace theazurerm_log_analytics_workspace_linked_service
resource.azurerm_postgresql_server
- support for version10
and10.2
azurerm_application_gateway
- deprecating thefqdn_list
field in favour offqdns
azurerm_application_gateway
- deprecating theip_address_list
field in favour ofip_addresses