Add Log Analytics support for ACI

[metacpp]

This PR is mainly to addressing the feature request in #2755, which includes:

1. log_analytics field support in ACI.
2. Fix the async issue in ACI CreateOrUpdate method.

[metacpp]

All tests passed:

[JunyiYi]

Thanks @metacpp for the contribution. The code looks good except some small issues. Once they are resolved, it would be good to go.

[metacpp]

@katbyte @JunyiYi Just updated PR, please review the changes.

[JunyiYi]

Thanks for the update and the code now looks good to me.

[metacpp]

All ACI tests passed:

[tombuildsstuff]

hi @metacpp

Thanks for pushing those changes - apologies for the delayed re-review here!

I've taken a look through and left some comments in-line but I feel like we need to better match the SDK here (by placing the log_analytics block within a diagnostics block) since it appears that multiple diagnostics options may be supported in the future, by virtue of this diagnostics wrapper existing.

Since there's a couple of out-of-scope changes which need to be made to the documentation for this resource to make this consistent - I'm going to push a commit to fix the highlighted issues and update the documentation; I hope you don't mind.

Thanks!

[tombuildsstuff]

since we're combining this into a diagnostics block, we should move this within the flattenContainerLogAnalytics function (since that handles returning an empty list if this is nil) such that this is set regardless

dismissing since changes have been pushed

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!