Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: azurerm_container_group : add log analytics workspace settings #2755

Closed
adnang opened this issue Jan 24, 2019 · 5 comments
Closed

Comments

@adnang
Copy link

adnang commented Jan 24, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We should add a log_analytics_workspace settings block to the azurerm_container_group resource which will enable integration with log analytics workspace.

New or Affected Resource(s)

  • azurerm_container_group

Potential Terraform Configuration

resource "azurerm_container_group" "aci-helloworld" {
  name                = "aci-hw"
  location            = "${azurerm_resource_group.aci-rg.location}"
  resource_group_name = "${azurerm_resource_group.aci-rg.name}"
  ip_address_type     = "public"
  dns_name_label      = "aci-label"
  os_type             = "Linux"

  container {
    name   = "hw"
    image  = "seanmckenna/aci-hellofiles"
    cpu    = "0.5"
    memory = "1.5"
    ports  = {
      port     = 80
      protocol = "TCP"
    }
  }

  log_analytics_workspace {
    workspace_id = "00000000-0000-0000-0000-000000000000"
    workspace_key = ""
  }
  
  tags {
    environment = "testing"
  }
}
@metacpp metacpp self-assigned this Jan 24, 2019
@metacpp metacpp changed the title azurerm_container_group : add log analytics workspace settings [Feature Request]azurerm_container_group : add log analytics workspace settings Jan 24, 2019
@metacpp metacpp changed the title [Feature Request]azurerm_container_group : add log analytics workspace settings Feature Request: azurerm_container_group : add log analytics workspace settings Jan 24, 2019
@metacpp
Copy link
Contributor

metacpp commented Jan 24, 2019

@adnang Thanks for opening this issue. I did a quick investigation on Azure Go SDK side, Our proposed schema is:

log_analytics {
  workspace_id = ""
  workspace_key = ""
  log_type = ""
  metadata {
     "test-key": "test-metadata-value"
   }
}

@adnang
Copy link
Author

adnang commented Jan 25, 2019

@metacpp looks good

@ghost ghost removed the waiting-response label Jan 25, 2019
@Lucretius
Copy link
Contributor

@tombuildsstuff looks like this one can be closed

@metacpp
Copy link
Contributor

metacpp commented Apr 3, 2019

@adnang The PR was merged in v1.23.0, so I am going to close this issue.

@metacpp metacpp closed this as completed Apr 3, 2019
@tombuildsstuff tombuildsstuff added this to the v1.23.0 milestone Apr 3, 2019
@ghost
Copy link

ghost commented May 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 3, 2019
@metacpp metacpp removed their assignment Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants