azurerm_kubernetes_cluster/azurerm_kubernetes_cluster_node_pool - add drain_timeout_in_minutes and node_soak_duration_in_minutes

[stephybun]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Supersedes #26022

Noticed some peculiar behaviour while fixing up #26022 which required the addition of a CustomizeDiff for drain_timeout_in_minutes, this issue was raised on the Swagger spec by @aristosvo for it. This property cannot be unset once configured and while the docs specify a default value of 30 minutes when omitted, this isn't returned by the API.

Testing

Tests look good, failures are unrelated.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• Data Source: azurerm_kubernetes_cluster - add support for the drain_timeout_in_minutes and node_soak_duration_in_minutes properties in the upgrade_settings block [GH-00000]
• azurerm_kubernetes_cluster - add support for the drain_timeout_in_minutes and node_soak_duration_in_minutes properties in the upgrade_settings block [GH-00000]
• azurerm_kubernetes_cluster_node_pool - add support for the drain_timeout_in_minutes and node_soak_duration_in_minutes properties in the upgrade_settings block [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #13066

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[aristosvo]

@stephybun FYI I raised Azure/azure-rest-api-specs#27373 for an earlier version of this PR

[stephybun]

Thanks for the reminder @aristosvo! The CustomizeDiff should work around that to a degree, but I'll link that issue you raised to it, since we should be able to remove it when it's fixed in the API.

[mbfrahry]

LGTM! Just a minor note to add a todo to update the docs for 4.0

[mbfrahry]

Could we add a TODO to add this default to the docs for 4.0?

[stephybun]

I am going to remove this since I found this did not work as expected when I did some 4.0 testing. I will open a follow up PR next week that will involve some 4.0 fixes for AKS, including a behavioural change to the upgrade_settings block

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.