azurerm_key_vault_managed_hardware_security_module: remove ForceNew for public_network_access_enabled

[wuxu92]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

The public_network_access_enabled should support update for manged HSM.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccKeyVaultManagedHardwareSecurityModule (1572.95s)
    --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/resource (1572.95s)
        --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/resource/update (1572.95s)
PASS

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_key_vault_managed_hardware_security_module - support update public_network_access_enabled property

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26044

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks @wuxu92. This looks mostly fine, but we need to use a different test to validate the update of this property. The basic test configs should only contain required properties.

[stephybun]

This is the config for the basic test which shouldn't have Optional properties in it. Can you please find another config/test to use to validate this case?

Suggested change

public_network_access_enabled = true

[wuxu92]

Sure, the public_network_access_enabled property is actually set to True by default. Therefore, I can simply remove this line from the basic config. However, can we still use basicUpdate to test the update of this property? Since most of the required properties of MSHM are also ForceNew, the basicUpdate config actually updates other non-required properties such as tags and network_acls.

[stephybun]

Sure, that's acceptable!

[wuxu92]

removed from basic.

[stephybun]

Same here, from the name of the config this is only checking whether the required properties are updateable.

Suggested change

public_network_access_enabled = false

[stephybun]

Thanks @wuxu92, the Terraform Schema Linting check just needs to be addressed now.

[wuxu92]

Thanks @stephybun linting issue addressed.

[stephybun]

Thanks @wuxu92 LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.