-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container_app_job
: support secrets from Key Vault
#25969
container_app_job
: support secrets from Key Vault
#25969
Conversation
9187e7a
to
87f7153
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Botje - We're having trouble running the tests for this PR due to some dependency changes/issues with main
that have crept in somewhere. Are you able to update your fork's main and rebase to allow us to run the tests?
Scratch that - sorry - appears to have been a problem with our CI system picking up changes... will loop back asap.
Despite subscribing to the linked issue, I did not get a notification. I will update the tests anyway, as promised. |
87f7153
to
e4da14d
Compare
Rebased on current |
e4da14d
to
15d989d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Botje - Thanks for the rebase and update. Just one minor docs change to look at and then I think this will be good to go, pending testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Botje for the updates. This LGTM, I'll get the tests run now.
<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.104.2" to "3.107.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.107.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.107.0
FEATURES:

* **New Resource:** `azurerm_data_protection_backup_policy_postgresql_flexible_server` ([#26024](https://github.com/hashicorp/terraform-provider-azurerm/issues/26024))

ENHANCEMENTS:

* dependencies: updating to `v0.20240604.1114748` of `github.com/hashicorp/go-azure-sdk` ([#26216](hashicorp/terraform-provider-azurerm#26216 `advisor`: update API version to `2023-01-01` ([#26205](hashicorp/terraform-provider-azurerm#26205 `keyvault`: handling the Resources API returning Key Vaults that have been deleted when populating the cache ([#26199](hashicorp/terraform-provider-azurerm#26199 `machinelearning`: update API version to `2024-04-01` ([#26168](hashicorp/terraform-provider-azurerm#26168 `network/privatelinkservices` - update to use `hashicorp/go-azure-sdk` ([#26212](hashicorp/terraform-provider-azurerm#26212 `network/serviceendpointpolicies` - update to use `hashicorp/go-azure-sdk` ([#26196](hashicorp/terraform-provider-azurerm#26196 `network/virtualnetworks` - update to use `hashicorp/go-azure-sdk` ([#26217](hashicorp/terraform-provider-azurerm#26217 `network/virtualwans`: update route resources to use `hashicorp/go-azure-sdk` ([#26189](hashicorp/terraform-provider-azurerm#26189 `azurerm_container_app_job` - support for the `key_vault_secret_id` and `identity` properties in the `secret` block ([#25969](hashicorp/terraform-provider-azurerm#25969 `azurerm_kubernetes_cluster` - support forthe `dns_zone_ids` popperty in the `web_app_routing` block ([#26117](hashicorp/terraform-provider-azurerm#26117 `azurerm_notification_hub_authorization_rule` - support for the `primary_connection_string` and `secondary_connection_string` properties ([#26188](hashicorp/terraform-provider-azurerm#26188 `azurerm_subnet` - support for the `default_outbound_access_enabled` property ([#25259](https://github.com/hashicorp/terraform-provider-azurerm/issues/25259))

BUG FIXES:

* `azurerm_api_management_named_value` - will now enforce setting the `secret` property when setting the `value_from_key_vault` property ([#26150](hashicorp/terraform-provider-azurerm#26150 `azurerm_storage_sync_server_endpoint` - improve pooling to work around api inconsistencies ([#26204](hashicorp/terraform-provider-azurerm#26204 `azurerm_virtual_network` - split create and update function to fix lifecycle - ignore ([#26246](hashicorp/terraform-provider-azurerm#26246 `azurerm_vpn_server_configuration` - split create and update function to fix lifecycle - ignore ([#26175](hashicorp/terraform-provider-azurerm#26175 `azurerm_vpn_server_configuration_policy_group` - split create and update function to fix lifecycle - ignore ([#26207](hashicorp/terraform-provider-azurerm#26207 `azurerm_vpn_site` - split create and update function to fix lifecycle - ignore changes ([#26163](https://github.com/hashicorp/terraform-provider-azurerm/issues/26163))

DEPRECATIONS:

* `azurerm_kubernetes_cluster` - the property `dns_zone_id` has been superseded by the property `dns_zone_ids` in the `web_app_routing` block ([#26117](hashicorp/terraform-provider-azurerm#26117 `azurerm_nginx_deployment` - the block `configuration` has been deprecated and superseded by the resource `azurerm_nginx_configuration` ([#25773](https://github.com/hashicorp/terraform-provider-azurerm/issues/25773))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/229/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Signed-off-by: Damien Duportal <[email protected]> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]> Co-authored-by: Damien Duportal <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
This PR adds support for referencing Key Vault secrets from Container App Jobs and lifts the restriction on removing secrets.
This code is ported from the Container Apps resource.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Testing evidence
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
container_app_job
- support secrets from Key Vault [GH-0000]container_app_job
- allow removing secrets [GH-0000]This is a (please select all that apply):
Related Issue(s)
Fixes #25934
Fixes #25994
Note
If this PR changes meaningfully during the course of review please update the title and description as required.