azurerm_notification_hub_authorization_rule - add primary_connection_string and secondary_connection_string computed attributes
#26188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofallops
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Hi @AlexPykavy - Thanks for this PR. Could you take a look at the question below?
thanks
Comment on lines
95
to
108
| "primary_connection_string": { | ||
| Type: pluginsdk.TypeString, | ||
| Computed: true, | ||
| }, | ||
|
|
||
| "secondary_connection_string": { | ||
| Type: pluginsdk.TypeString, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
Should these properties not be marked as Sensitive: true? I think the above access keys should also be so, but that would possibly be a breaking change at this point, but could be prepared for 4.0 using Sensitive: !features.FourPointOhBeta()?
There was a problem hiding this comment.
Good point! Sure, I'll correct them.
…on_string` and `secondary_connection_string` computed attributes
jackofallops
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Hi @AlexPykavy - Thanks for the quick turnaround on those changes, LGTM now 👍
jackofallops
added a commit
that referenced
this pull request
Jun 3, 2024
dduportal
added a commit
to jenkins-infra/azure
that referenced
this pull request
Jun 11, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azurerm" updated from
"3.104.2" to "3.107.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>3.107.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.107.0
FEATURES:

*
**New Resource:**
`azurerm_data_protection_backup_policy_postgresql_flexible_server`
([#26024](https://github.com/hashicorp/terraform-provider-azurerm/issues/26024))

ENHANCEMENTS:

*
dependencies: updating to `v0.20240604.1114748` of
`github.com/hashicorp/go-azure-sdk`
([#26216](hashicorp/terraform-provider-azurerm#26216
`advisor`: update API version to `2023-01-01`
([#26205](hashicorp/terraform-provider-azurerm#26205
`keyvault`: handling the Resources API returning Key Vaults that have
been deleted when populating the cache
([#26199](hashicorp/terraform-provider-azurerm#26199
`machinelearning`: update API version to `2024-04-01`
([#26168](hashicorp/terraform-provider-azurerm#26168
`network/privatelinkservices` - update to use `hashicorp/go-azure-sdk`
([#26212](hashicorp/terraform-provider-azurerm#26212
`network/serviceendpointpolicies` - update to use
`hashicorp/go-azure-sdk`
([#26196](hashicorp/terraform-provider-azurerm#26196
`network/virtualnetworks` - update to use `hashicorp/go-azure-sdk`
([#26217](hashicorp/terraform-provider-azurerm#26217
`network/virtualwans`: update route resources to use
`hashicorp/go-azure-sdk`
([#26189](hashicorp/terraform-provider-azurerm#26189
`azurerm_container_app_job` - support for the `key_vault_secret_id` and
`identity` properties in the `secret` block
([#25969](hashicorp/terraform-provider-azurerm#25969
`azurerm_kubernetes_cluster` - support forthe `dns_zone_ids` popperty in
the `web_app_routing` block
([#26117](hashicorp/terraform-provider-azurerm#26117
`azurerm_notification_hub_authorization_rule` - support for the
`primary_connection_string` and `secondary_connection_string` properties
([#26188](hashicorp/terraform-provider-azurerm#26188
`azurerm_subnet` - support for the `default_outbound_access_enabled`
property
([#25259](https://github.com/hashicorp/terraform-provider-azurerm/issues/25259))

BUG
FIXES:

* `azurerm_api_management_named_value` - will now
enforce setting the `secret` property when setting the
`value_from_key_vault` property
([#26150](hashicorp/terraform-provider-azurerm#26150
`azurerm_storage_sync_server_endpoint` - improve pooling to work around
api inconsistencies
([#26204](hashicorp/terraform-provider-azurerm#26204
`azurerm_virtual_network` - split create and update function to fix
lifecycle - ignore
([#26246](hashicorp/terraform-provider-azurerm#26246
`azurerm_vpn_server_configuration` - split create and update function to
fix lifecycle - ignore
([#26175](hashicorp/terraform-provider-azurerm#26175
`azurerm_vpn_server_configuration_policy_group` - split create and
update function to fix lifecycle - ignore
([#26207](hashicorp/terraform-provider-azurerm#26207
`azurerm_vpn_site` - split create and update function to fix lifecycle -
ignore changes
([#26163](https://github.com/hashicorp/terraform-provider-azurerm/issues/26163))

DEPRECATIONS:

*
`azurerm_kubernetes_cluster` - the property `dns_zone_id` has been
superseded by the property `dns_zone_ids` in the `web_app_routing` block
([#26117](hashicorp/terraform-provider-azurerm#26117
`azurerm_nginx_deployment` - the block `configuration` has been
deprecated and superseded by the resource `azurerm_nginx_configuration`
([#25773](https://github.com/hashicorp/terraform-provider-azurerm/issues/25773))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/229/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
---------
Signed-off-by: Damien Duportal <[email protected]>
Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Co-authored-by: Damien Duportal <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.