azurerm_kubernetes_cluster support for open_service_mesh

[JasonWhall]

Reworked from existing PR #11189 to address remaining comments.

Fixes #13434

[tombuildsstuff]

LGTM - thanks for this @JasonWhall

[katbyte]

looks like we may have an eventually consistent error in the tests:

------- Stdout: -------
=== RUN   TestAccDataSourceKubernetesCluster_addOnProfileOpenServiceMesh
=== PAUSE TestAccDataSourceKubernetesCluster_addOnProfileOpenServiceMesh
=== CONT  TestAccDataSourceKubernetesCluster_addOnProfileOpenServiceMesh
    testcase.go:88: Step 1/1 error: Check failed: Check 2/2 error: azurerm_kubernetes_cluster.test: Attribute 'addon_profile.0.open_service_mesh.0.enabled' expected "true", got "false"
--- FAIL: TestAccDataSourceKubernetesCluster_addOnProfileOpenServiceMesh (529.14s)
FAIL

[JasonWhall]

@katbyte This should now be correct. I originally enabled OSM as part of the tests, however it seems the pattern for other addons is to explicitly disable the addon as part of the test. I missed one check for this! 😄

[tombuildsstuff]

@JasonWhall thanks for pushing that fix - however rather than setting this value to false, can we test this can be turned on and off - first by setting enabled to true and then false to validate this works end to end? This can be done using multiple test steps:

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go

Lines 355 to 362 in e0dfaa5

	{
	Config: r.addonProfileOpenServiceMeshConfig(data),
	Check: acceptance.ComposeTestCheckFunc(
	check.That(data.ResourceName).ExistsInAzure(r),
	check.That(data.ResourceName).Key("addon_profile.0.open_service_mesh.#").HasValue("1"),
	check.That(data.ResourceName).Key("addon_profile.0.open_service_mesh.0.enabled").HasValue("false"),
	),
	},

[JasonWhall]

@tombuildsstuff I've updated the acc tests to include the enable and disable steps as suggested 🍻

tests result:

=== RUN   TestAccKubernetesCluster_addonProfileOpenServiceMesh
=== PAUSE TestAccKubernetesCluster_addonProfileOpenServiceMesh
=== CONT  TestAccKubernetesCluster_addonProfileOpenServiceMesh
--- PASS: TestAccKubernetesCluster_addonProfileOpenServiceMesh (678.86s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    680.743s

[tombuildsstuff]

LGTM - thanks for pushing those changes @JasonWhall

[github-actions]

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.