Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure service_tag headers in ip_restrictions azurerm_app_service #11156

Closed
MarkPerry24 opened this issue Mar 30, 2021 · 2 comments · Fixed by #11209
Closed

Support for Azure service_tag headers in ip_restrictions azurerm_app_service #11156

MarkPerry24 opened this issue Mar 30, 2021 · 2 comments · Fixed by #11209

Comments

@MarkPerry24
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

For Services such as securing FrontDoor access to web services it is currently not possible to restrict using the service tag + unique identifier of your specific front door without deploying via ARM template or Azure Cli tasks.

New or Affected Resource(s)

  • azurerm_app_service

Potential Terraform Configuration

add support for headers in similar way to ARM template. e.g. https://docs.microsoft.com/en-us/azure/templates/microsoft.web/sites/config-web?tabs=json

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@aristosvo
Copy link
Collaborator

aristosvo commented Mar 31, 2021

This shouldn't be too hard, I'll try to pick this up if the REST APIs support it. Probably for ip_scm_restrictions as well.

katbyte pushed a commit that referenced this issue Apr 27, 2021
…app`: Support for site_config.ip_restrictions.headers / site_config.scm_ip_restrictions.headers (#11209)

Fixes #11156
alvintang pushed a commit to alvintang/terraform-provider-azurerm that referenced this issue Apr 29, 2021
…app`: Support for site_config.ip_restrictions.headers / site_config.scm_ip_restrictions.headers (hashicorp#11209)

Fixes hashicorp#11156
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.