add public network access to container registry

[ms-henglu]

To address issue #7334

Below paste the run pass result for th test cases

=== RUN   TestAccContainerRegistry_update
=== PAUSE TestAccContainerRegistry_update
=== CONT  TestAccContainerRegistry_update
--- PASS: TestAccContainerRegistry_update (213.56s)
PASS

=== RUN   TestAccContainerRegistry_networkAccessProfileIp
=== PAUSE TestAccContainerRegistry_networkAccessProfileIp
=== CONT  TestAccContainerRegistry_networkAccessProfileIp
--- PASS: TestAccContainerRegistry_networkAccessProfileIp (161.77s)
PASS

=== RUN   TestAccContainerRegistry_geoReplication
=== PAUSE TestAccContainerRegistry_geoReplication
=== CONT  TestAccContainerRegistry_geoReplication
--- PASS: TestAccContainerRegistry_geoReplication (856.19s)
PASS

[katbyte]

Thanks @ms-henglu - LGTM 👍

[katbyte]

Looks like we have a test failure, could we fix it to make sure its not from the api upgrade:

------- Stdout: -------
=== RUN   TestAccContainerRegistry_geoReplication
=== PAUSE TestAccContainerRegistry_geoReplication
=== CONT  TestAccContainerRegistry_geoReplication
    testing.go:620: Step 1/5 error: Check failed: Check 4/5 error: azurerm_container_registry.test: Attribute 'georeplication_locations.0' expected "westeurope", got "eastus2"
--- FAIL: TestAccContainerRegistry_geoReplication (214.52s)
FAIL

------- Stderr: -------
2021/03/17 23:57:52 [DEBUG] not using binary driver name, it's no longer needed
2021/03/17 23:57:52 [DEBUG] not using binary driver name, it's no longer needed

[ms-henglu]

@katbyte Thanks for code review. I added a commit to fix the test. By the way, the test fails before API upgrade. Please review again. Thanks!

[katbyte]

Thanks @ms-henglu - LGTM 👍

[ghost]

This has been released in version 2.53.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.53.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!