Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IoT Analytics Service #9931

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Added IoT Analytics Service #9931

merged 3 commits into from
Sep 4, 2019

Conversation

ktarasz
Copy link
Contributor

@ktarasz ktarasz commented Aug 30, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9930

Release note for CHANGELOG:

Add IoT Analytics Service

@ktarasz ktarasz requested a review from a team August 30, 2019 12:19
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. dependencies Used to indicate dependency changes. labels Aug 30, 2019
@ktarasz ktarasz force-pushed the iotanalytics_service branch from 207f633 to 4c774b9 Compare August 30, 2019 12:31
@ktarasz ktarasz force-pushed the iotanalytics_service branch from 4c774b9 to 86f7234 Compare August 30, 2019 12:32
@ktarasz ktarasz mentioned this pull request Aug 30, 2019
Closed
@bflad bflad added this to the v2.27.0 milestone Aug 30, 2019
bflad
bflad suggested changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ktarasz 👋 Thanks for submitting this. Can you please also add the website documentation (Contributing Guide reference)?

In website/docs/guides/custom-service-endpoints.html.md: Add the service name in the list of customizable endpoints.

After that this should be good to get in. Thanks!

@ghost ghost added the documentation Introduces or discusses updates to documentation. label Sep 2, 2019
bflad
bflad approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ktarasz 🚀

@bflad bflad merged commit 30ee3dd into hashicorp:master Sep 4, 2019
@ghost
Copy link

ghost commented Sep 5, 2019

This has been released in version 2.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ktarasz @bflad