Added point_in_time_restore to aws_rds_cluster

[tkawachi]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #2321

Release note for CHANGELOG:

- resource/aws_rds_cluster: Add `point_in_time_restore` attribute.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_pointInTimeRestore'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSRDSCluster_pointInTimeRestore -timeout 120m
=== RUN   TestAccAWSRDSCluster_pointInTimeRestore
=== PAUSE TestAccAWSRDSCluster_pointInTimeRestore
=== CONT  TestAccAWSRDSCluster_pointInTimeRestore
--- PASS: TestAccAWSRDSCluster_pointInTimeRestore (370.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	370.342s

[tkawachi]

Hi, this is almost my first try to program in golang and to modify a terraform plugin. Please let me know if you have any advice. Thank you.

[GryshchenkoAndrii]

@tkawachi what's the situation on this? Are we going forward with the change?

[internetrush1]

@tkawachi this just waiting on rebase or whats the liklihood this will make it in?

[tkawachi]

Unfortunately, there are too many conflicts to simply rebase. It would be great if someone could take over as I don't have the time to do so.

[lorengordon]

Is this pr duplicating the feature this one is implementing? #7031?

[anGie44]

I believe so @lorengordon. @tkawachi please note #7031 is currently under review and aims to add the argument presented here. Thank you for your time and efforts in creating this PR! Please reach out if you have any additional questions or concerns :)

[tkawachi]

@lorengordon @anGie44 It seems that #7031 is tackling the same feature (and still alive 😄 ).

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!