Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect actual argument names for aws_backup_selection in docs #8212

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

grom3k
Copy link
Contributor

@grom3k grom3k commented Apr 5, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Complements #7382

Documentation for aws_backup_selection is not updated resulting in following error, while trying create the resource:

Error: aws_backup_selection.efs_backup: "iam_role_arn": required field is not set
Error: aws_backup_selection.efs_backup: : invalid or unknown key: iam_role
Error: aws_backup_selection.efs_backup: : invalid or unknown key: tag

I've updated the documentation to reflect proper arguments names

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Apr 5, 2019
@bflad bflad added the service/backup Issues and PRs that pertain to the backup service. label Apr 5, 2019
@bflad bflad added this to the v2.6.0 milestone Apr 5, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @grom3k

@bflad bflad merged commit 26503b3 into hashicorp:master Apr 5, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/backup Issues and PRs that pertain to the backup service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants