Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kinesis_analytics_application: support multiple outputs #7535

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Feb 13, 2019

Fixes #7506

Changes proposed in this pull request:

  • support mutliple outputs

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_'
==> Fixing source code with gofmt...
gofmt -s -w ./aws
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_update
=== RUN   TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_update
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== CONT  TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsAdd
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (8.12s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (12.06s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (24.67s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (28.16s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (32.06s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (32.33s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (32.50s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (45.36s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (87.07s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (87.08s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (87.62s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (101.93s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (102.58s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (169.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (169.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	169.903s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 13, 2019
@bflad bflad added service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. bug Addresses a defect in current functionality. labels Feb 13, 2019
@bflad bflad added this to the v1.59.0 milestone Feb 13, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this so quickly, @kl4w! 🚀

Previous output from acceptance testing:

--- FAIL: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (84.44s)
    testing.go:538: Step 0 error: Check failed: Check 2/2 error: aws_kinesis_analytics_application.test: Attribute 'outputs.#' expected "2", got "1"

Output from acceptance testing:

--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (8.77s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (13.07s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (24.71s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (27.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (32.27s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (33.38s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (33.54s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (71.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (87.62s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (87.79s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (87.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (103.96s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (105.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (180.16s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (180.16s)

@bflad bflad merged commit 536af19 into hashicorp:master Feb 13, 2019
bflad added a commit that referenced this pull request Feb 13, 2019
@kl4w kl4w deleted the support-multiple-outputs branch February 13, 2019 18:44
@bflad
Copy link
Contributor

bflad commented Feb 14, 2019

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Kinesis Analytics Application only reads the first element in the outputs list
2 participants