Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force destroy support for Transfer Server #6935

Conversation

teraken0509
Copy link
Contributor

When destroy aws_transfer_server resource with users not managed by terraform, the apply would be failed.

Changes proposed in this pull request:

  • Add force_destroy attribute to aws_transfer_server resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSTransferServer_forcedestroy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSTransferServer_forcedestroy -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSTransferServer_forcedestroy
=== PAUSE TestAccAWSTransferServer_forcedestroy
=== CONT  TestAccAWSTransferServer_forcedestroy
--- PASS: TestAccAWSTransferServer_forcedestroy (33.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.046s
...

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 20, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. labels Dec 21, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @kterada0509, especially writing up the covering acceptance test. 🚀

--- PASS: TestAccAWSTransferServer_disappears (3.90s)
--- PASS: TestAccAWSTransferServer_apigateway (7.93s)
--- PASS: TestAccAWSTransferServer_forcedestroy (8.57s)
--- PASS: TestAccAWSTransferServer_basic (11.56s)

@bflad bflad added this to the v1.54.0 milestone Dec 21, 2018
@bflad bflad merged commit f9f609d into hashicorp:master Dec 21, 2018
bflad added a commit that referenced this pull request Dec 21, 2018
@bflad
Copy link
Contributor

bflad commented Dec 21, 2018

This has been released in version 1.54.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-force-destroy-support-for-transfer-server branch March 5, 2020 14:01
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants