Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gosimple: Fix WAF-related issues #6402

Merged
merged 1 commit into from
Nov 12, 2018
Merged

gosimple: Fix WAF-related issues #6402

merged 1 commit into from
Nov 12, 2018

Conversation

YakDriver
Copy link
Member

Related to #6343 technical debt

Changes proposed in this pull request:

  • Fixes for all WAF-related tests and resources

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafByteMatchSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafByteMatchSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafByteMatchSet_basic
=== PAUSE TestAccAWSWafByteMatchSet_basic
=== CONT  TestAccAWSWafByteMatchSet_basic
--- PASS: TestAccAWSWafByteMatchSet_basic (16.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.916s

$ make testacc TESTARGS='-run=TestAccAWSWafRuleGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRuleGroup_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRuleGroup_basic
=== PAUSE TestAccAWSWafRuleGroup_basic
=== CONT  TestAccAWSWafRuleGroup_basic
--- PASS: TestAccAWSWafRuleGroup_basic (21.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.154s

$ make testacc TESTARGS='-run=TestAccAWSWafSizeConstraintSet_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafSizeConstraintSet_disappears -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafSizeConstraintSet_disappears
=== PAUSE TestAccAWSWafSizeConstraintSet_disappears
=== CONT  TestAccAWSWafSizeConstraintSet_disappears
--- PASS: TestAccAWSWafSizeConstraintSet_disappears (16.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.865s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalSqlInjectionMatchSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalSqlInjectionMatchSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalSqlInjectionMatchSet_basic
=== PAUSE TestAccAWSWafRegionalSqlInjectionMatchSet_basic
=== CONT  TestAccAWSWafRegionalSqlInjectionMatchSet_basic
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_basic (18.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.188s

$ make testacc TESTARGS='-run=TestAccAWSWafXssMatchSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafXssMatchSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafXssMatchSet_basic
=== PAUSE TestAccAWSWafXssMatchSet_basic
=== CONT  TestAccAWSWafXssMatchSet_basic
--- PASS: TestAccAWSWafXssMatchSet_basic (18.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.068s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalIPSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalIPSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalIPSet_basic
=== PAUSE TestAccAWSWafRegionalIPSet_basic
=== CONT  TestAccAWSWafRegionalIPSet_basic
--- PASS: TestAccAWSWafRegionalIPSet_basic (17.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.384s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalRule_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalRule_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalRule_basic
=== PAUSE TestAccAWSWafRegionalRule_basic
=== CONT  TestAccAWSWafRegionalRule_basic
--- PASS: TestAccAWSWafRegionalRule_basic (31.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.368s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalRuleGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalRuleGroup_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalRuleGroup_basic
=== PAUSE TestAccAWSWafRegionalRuleGroup_basic
=== CONT  TestAccAWSWafRegionalRuleGroup_basic
--- PASS: TestAccAWSWafRegionalRuleGroup_basic (24.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.707s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalSizeConstraintSet_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalSizeConstraintSet_disappears -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalSizeConstraintSet_disappears
=== PAUSE TestAccAWSWafRegionalSizeConstraintSet_disappears
=== CONT  TestAccAWSWafRegionalSizeConstraintSet_disappears
--- PASS: TestAccAWSWafRegionalSizeConstraintSet_disappears (15.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.170s

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalWebAclAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRegionalWebAclAssociation -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalWebAclAssociation_basic
=== PAUSE TestAccAWSWafRegionalWebAclAssociation_basic
=== RUN   TestAccAWSWafRegionalWebAclAssociation_multipleAssociations
=== PAUSE TestAccAWSWafRegionalWebAclAssociation_multipleAssociations
=== CONT  TestAccAWSWafRegionalWebAclAssociation_basic
=== CONT  TestAccAWSWafRegionalWebAclAssociation_multipleAssociations
--- PASS: TestAccAWSWafRegionalWebAclAssociation_multipleAssociations (255.93s)
--- PASS: TestAccAWSWafRegionalWebAclAssociation_basic (265.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	265.754s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 8, 2018
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 8, 2018
@YakDriver YakDriver mentioned this pull request Nov 8, 2018
Closed
2 tasks
@bflad bflad added this to the v1.44.0 milestone Nov 8, 2018
bflad
bflad approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passes WAF acceptance testing just fine as well. Thanks, @YakDriver! 🚀

@bflad bflad merged commit 9d152f3 into hashicorp:master Nov 12, 2018
@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/waf Issues and PRs that pertain to the waf service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad