-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamelift Game Session Queue #6335
Conversation
@bflad I think I did everything you asked for and this PR is ready for another review. |
acb1d23
to
90371dd
Compare
I've started to implement a resource for matchmaking configurations but to properly test it I need a game session queue because game session queue ARN is one of the required parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again @Hinidu 👋 Thanks so much for the updates! This is pretty close. We should be able to get this in after these minor changes (up to you if you want to implement import or not, but we should change the ID before releasing the initial resource).
Hello @bflad! I've replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @Hinidu! LGTM 🚀
--- PASS: TestAccAWSGameliftGameSessionQueue_basic (21.46s)
Nice! Thank you @bflad for your feedback and merge! Hopefully I will try to implement other GameLift resources soon. |
This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Replacement for #5397
Original issue #2546
Changes proposed in this pull request:
aws_gamelift_session_queue
Output from acceptance testing:
The only think I didn't changed is
playerLatencyPolicies
:Because there can be many policies.