Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamelift Game Session Queue #6335

Merged
merged 15 commits into from
Nov 14, 2018
Merged

Conversation

Hinidu
Copy link
Contributor

@Hinidu Hinidu commented Nov 2, 2018

Replacement for #5397
Original issue #2546

Changes proposed in this pull request:

  • New resource aws_gamelift_session_queue

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGameliftGameSessionQueue_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSGameliftGameSessionQueue_basic -timeout 120m
=== RUN   TestAccAWSGameliftGameSessionQueue_basic
--- PASS: TestAccAWSGameliftGameSessionQueue_basic (38.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.630s

The only think I didn't changed is playerLatencyPolicies:

Can there be multiple of these configurations? If not, we should set MaxItems: 1 for this attribute +1

Because there can be many policies.

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/gamelift Issues and PRs that pertain to the gamelift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 2, 2018
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Nov 2, 2018
@Hinidu
Copy link
Contributor Author

Hinidu commented Nov 2, 2018

@bflad I think I did everything you asked for and this PR is ready for another review.

@Hinidu Hinidu force-pushed the gamelift-session-queue branch from acb1d23 to 90371dd Compare November 2, 2018 16:07
@Hinidu Hinidu changed the title Gamelift session queue Gamelift Game Session Queue Nov 2, 2018
@Hinidu
Copy link
Contributor Author

Hinidu commented Nov 3, 2018

I've started to implement a resource for matchmaking configurations but to properly test it I need a game session queue because game session queue ARN is one of the required parameters.

@bflad bflad added the new-resource Introduces a new resource. label Nov 5, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again @Hinidu 👋 Thanks so much for the updates! This is pretty close. We should be able to get this in after these minor changes (up to you if you want to implement import or not, but we should change the ID before releasing the initial resource).

aws/resource_aws_gamelift_game_session_queue.go Outdated Show resolved Hide resolved
aws/resource_aws_gamelift_game_session_queue.go Outdated Show resolved Hide resolved
aws/resource_aws_gamelift_game_session_queue.go Outdated Show resolved Hide resolved
aws/resource_aws_gamelift_game_session_queue.go Outdated Show resolved Hide resolved
aws/resource_aws_gamelift_game_session_queue.go Outdated Show resolved Hide resolved
aws/resource_aws_gamelift_game_session_queue.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 13, 2018
@Hinidu
Copy link
Contributor Author

Hinidu commented Nov 14, 2018

Hello @bflad! I've replaced ARN by Name as ID and added the import.

@bflad bflad added this to the v1.44.0 milestone Nov 14, 2018
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 14, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @Hinidu! LGTM 🚀

--- PASS: TestAccAWSGameliftGameSessionQueue_basic (21.46s)

@bflad bflad merged commit 704805e into hashicorp:master Nov 14, 2018
bflad added a commit that referenced this pull request Nov 14, 2018
@Hinidu Hinidu deleted the gamelift-session-queue branch November 14, 2018 15:39
@Hinidu
Copy link
Contributor Author

Hinidu commented Nov 14, 2018

Nice! Thank you @bflad for your feedback and merge! Hopefully I will try to implement other GameLift resources soon.

@bflad
Copy link
Contributor

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/gamelift Issues and PRs that pertain to the gamelift service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants