Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_pinpoint_apns_sandbox_channel #6233

Merged

Conversation

marcoreni
Copy link
Contributor

@marcoreni marcoreni commented Oct 22, 2018

Work continues on #4990

Changes proposed in this pull request:

  • New resource aws_pinpoint_apns_sandbox_channel with related docs and acceptance tests

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSPinpointAPNSSandboxChannel'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSPinpointAPNSSandboxChannel -timeout 120m
=== RUN   TestAccAWSPinpointAPNSSandboxChannel_basicCertificate
--- PASS: TestAccAWSPinpointAPNSSandboxChannel_basicCertificate (34.86s)
=== RUN   TestAccAWSPinpointAPNSSandboxChannel_basicToken
--- PASS: TestAccAWSPinpointAPNSSandboxChannel_basicToken (30.22s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       65.135s

NOTES:

  • The tests require two set of credentials, one for TLS certificate credentials and the other for key credentials. The two tests are independent from each other, and inside the test file I referenced Apple docs about retrieving the credentials. It's possible to create a "universal" certificate and to use that for both production (aws_pinpoint_apns_channel) and sandbox (aws_pinpoint_apns_sandbox_channel) resources tests.

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 22, 2018
@bflad bflad added new-resource Introduces a new resource. service/pinpoint Issues and PRs that pertain to the pinpoint service. labels Oct 25, 2018
@bflad bflad added this to the v1.42.0 milestone Oct 25, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given the other Pinpoint resource implementations. Thanks @marcoreni! 🚀

@bflad bflad merged commit 43922f9 into hashicorp:master Oct 25, 2018
bflad added a commit that referenced this pull request Oct 25, 2018
@marcoreni marcoreni deleted the feature/4990_pinpoint_apns_sandbox_channel branch October 26, 2018 11:36
@marcoreni marcoreni mentioned this pull request Oct 26, 2018
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. service/pinpoint Issues and PRs that pertain to the pinpoint service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants