Fixes #2384 aws_cloudwatch_log_metric_filter: default_value is automatically set to 0

[ahl]

Fixes #2384

Note I looked at #2759 and #2902 which were both old and incomplete
cc: @jocelynthode @modax

Changes proposed in this pull request:

• use sentinel value of NaN to indicate that no value was specified
• clean up misspelling and cruft

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogMetricFilter_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchLogMetricFilter_* -timeout 120m
=== RUN   TestAccAWSCloudWatchLogMetricFilter_basic
--- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (18.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.743s

[ahl]

I should also have noted that a better solution is blocked on this issue: https://github.com/hashicorp/terraform/issues/16796

[ahl]

@radeksimko take a look?

[ahl]

maybe @bflad you could take a look?

[paultyng]

I think we should implement this instead as a TypeString so that empty string can represent the unset value. We have precedent for this with TypeBool's https://github.com/terraform-providers/terraform-provider-aws/blob/502d7b4cfa74d5a0715e6ba32f60d4ad58e2cbd7/aws/resource_aws_launch_template.go#L92-L95

It's definitely an annoying limitation of the current type system, and potentially something we can address post 0.12, but the backwards compatible implementation will probably just use a TypeString as well.

While talking with @bflad about this, our consensus is that if we have to do a hack to support it, we should at least be consistent in our hacks.

[ahl]

Makes sense; I'll update the PR

[jocelynthode]

I think you could have pushed to my branch so that we would have consolidated on a single PR. Anyway, I'll close mine as it is not needed anymore.

[ahl]

@jocelynthode I didn't know that was possible; thanks.

[ahl]

@paultyng much better approach; thanks.

Looks like resource_aws_spot_fleet_request.go is doing the same thing more or less.

[ahl]

@paultyng added the unit test and fixed the bug that you found

[bflad]

LGTM, thanks so much for this fix and patience @ahl! 🚀

--- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (6.56s)

[paultyng]

@ahl thanks for following up on this one!

[ahl]

@paultyng it's pretty critical to us so I was motivated; thanks for sticking with me on it.

[bflad]

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!