Add import for aws_iam_role_policy_attachment

[jzbruno]

Fixes #544

Changes proposed in this pull request:

• Add import for aws_iam_role_policy_attachment without changing create behavior. See previous discussion on PR Add import to aws_iam_role_policy_attachment #4527

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRolePolicyAttachment_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSRolePolicyAttachment_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSRolePolicyAttachment_basic
--- PASS: TestAccAWSRolePolicyAttachment_basic (25.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.256s

[bflad]

LGTM, thanks @jzbruno! 🚀 Please note I made the minor adjustment in a followup commit and added some comments about the lack of ImportStateVerify.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRolePolicyAttachment_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRolePolicyAttachment_basic -timeout 120m
=== RUN   TestAccAWSRolePolicyAttachment_basic
--- PASS: TestAccAWSRolePolicyAttachment_basic (16.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.920s

[bflad]

Minor nitpick: For future maintainability, we should parameterize this and only depend on the resource in question (aws_iam_role_policy_attachment). e.g.

func testAccAWSIAMRolePolicyAttachmentImportStateIdFunc(resourceName string) resource.ImportStateIdFunc {
	return func(s *terraform.State) (string, error) {
		rs, ok := s.RootModule().Resources[resourceName]
		if !ok {
			return "", fmt.Errorf("Not found: %s", resourceName)
		}

		return fmt.Sprintf("%s/%s", rs.Primary.Attributes["role"], rs.Primary.Attributes["policy_arn"]), nil
	}
}

[bflad]

This has been released in version 1.37.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!