Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: go-ini/[email protected] #5712

Merged
merged 2 commits into from
Aug 28, 2018
Merged

vendor: go-ini/[email protected] #5712

merged 2 commits into from
Aug 28, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 28, 2018

To match aws/[email protected] go.mod: https://github.com/aws/aws-sdk-go/blob/29a1971386925052e4dbdd34cfc8c367f95119cc/go.mod#L4

Changes proposed in this pull request:

Output from unit testing:

$ make test TEST=./aws
==> Checking that code complies with gofmt requirements...
go test ./aws -timeout=30s -parallel=4
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.343s

@bflad
vendor: go-ini/[email protected]
d7e1405 
To match aws/[email protected] go.mod

Updated via: `govendor fetch github.com/go-ini/ini/[email protected]`

```
$ make test TEST=./aws
==> Checking that code complies with gofmt requirements...
go test ./aws -timeout=30s -parallel=4
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.343s
```
@bflad bflad added dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. labels Aug 28, 2018
@bflad bflad requested a review from a team August 28, 2018 17:33
@ghost ghost added the dependencies Used to indicate dependency changes. label Aug 28, 2018
tombuildsstuff
tombuildsstuff approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.34.0 milestone Aug 28, 2018
@ghost ghost added the dependencies Used to indicate dependency changes. label Aug 28, 2018
@bflad bflad merged commit d24288b into master Aug 28, 2018
@bflad bflad deleted the v-go-ini-v1.25.4 branch August 28, 2018 19:40
@bflad
Copy link
Contributor Author

bflad commented Sep 4, 2018

Reference: #5773

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS.
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff