resource/aws_glue_crawler: Additional IAM eventual consistency retry logic for create and update

[bflad]

Found via daily acceptance testing:

=== RUN   TestAccAWSGlueCrawler_JdbcTarget
--- FAIL: TestAccAWSGlueCrawler_JdbcTarget (15.36s)
	testing.go:518: Step 0 error: Error applying: 1 error occurred:
			* aws_glue_crawler.test: 1 error occurred:
			* aws_glue_crawler.test: error creating Glue crawler: InvalidInputException: Unable to retrieve connection tf-acc-test-8656357591012534997: User: arn:aws:sts::*******:assumed-role/tf-acc-test-8656357591012534997/AWS-Crawler is not authorized to perform: glue:GetConnection on resource: * (Service: AmazonDataCatalog; Status Code: 400; Error Code: AccessDeniedException; Request ID: 4d72b66f-9c75-11e8-9faf-5b526c7be968)
			status code: 400, request id: 4d006c65-9c75-11e8-8046-97727676b4c1

Changes proposed in this pull request:

• Add IAM retry logic during update as well since the IAM role can be updated
• Retry on additional "not authorized" type IAM error

Output from acceptance testing:

14 tests passed (all tests)
=== RUN   TestAccAWSGlueCrawler_recreates
--- PASS: TestAccAWSGlueCrawler_recreates (24.49s)
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (33.79s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (38.85s)
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (45.76s)
=== RUN   TestAccAWSGlueCrawler_Configuration
--- PASS: TestAccAWSGlueCrawler_Configuration (46.56s)
=== RUN   TestAccAWSGlueCrawler_Schedule
--- PASS: TestAccAWSGlueCrawler_Schedule (49.26s)
=== RUN   TestAccAWSGlueCrawler_Description
--- PASS: TestAccAWSGlueCrawler_Description (53.83s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (57.08s)
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (57.66s)
=== RUN   TestAccAWSGlueCrawler_Classifiers
--- PASS: TestAccAWSGlueCrawler_Classifiers (59.75s)
=== RUN   TestAccAWSGlueCrawler_TablePrefix
--- PASS: TestAccAWSGlueCrawler_TablePrefix (64.98s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (79.58s)
=== RUN   TestAccAWSGlueCrawler_S3Target
--- PASS: TestAccAWSGlueCrawler_S3Target (81.50s)
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (83.72s)

[tombuildsstuff]

LGTM 👍

[bflad]

This has been released in version 1.32.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!