Supress ES domain dedicated master changes if it is disabled

[julienduchesne]

Changes proposed in this pull request:

• The dedicated_master_count and dedicated_master_type attributes are not updated or read from the API if the dedicated_master_enabled argument is set to false. This causes plans to always have changes if these attributes are always set.

Output from acceptance testing:

TESTARGS='-run=TestAccAWSElasticSearchDomain_withDedicatedMaster'  make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSElasticSearchDomain_withDedicatedMaster -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSElasticSearchDomain_withDedicatedMaster
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (2410.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2410.310s

[bflad]

Given how the API works, this seems like it is probably the right course of action here. Thanks @julienduchesne! 🚀

This PR will close #252.

(Test failure unrelated)

Tests failed: 1 (1 new), passed: 18
=== RUN   TestAccAWSElasticSearchDomain_duplicate
--- PASS: TestAccAWSElasticSearchDomain_duplicate (969.94s)
=== RUN   TestAccAWSElasticSearchDomain_basic
--- PASS: TestAccAWSElasticSearchDomain_basic (1564.29s)
=== RUN   TestAccAWSElasticSearchDomain_policy
--- PASS: TestAccAWSElasticSearchDomain_policy (1577.52s)
=== RUN   TestAccAWSElasticSearchDomain_v23
--- PASS: TestAccAWSElasticSearchDomain_v23 (1716.35s)
=== RUN   TestAccAWSElasticSearchDomain_complex
--- PASS: TestAccAWSElasticSearchDomain_complex (1778.77s)
=== RUN   TestAccAWSElasticSearchDomain_importBasic
--- PASS: TestAccAWSElasticSearchDomain_importBasic (1779.11s)
=== RUN   TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (2462.28s)
=== RUN   TestAccAWSElasticSearchDomain_LogPublishingOptions
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (2561.30s)
=== RUN   TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (2645.68s)
=== RUN   TestAccAWSElasticSearchDomainPolicy_basic
--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (2679.02s)
=== RUN   TestAccAWSElasticSearchDomain_tags
--- PASS: TestAccAWSElasticSearchDomain_tags (2782.38s)
=== RUN   TestAccAWSElasticSearchDomain_vpc
--- PASS: TestAccAWSElasticSearchDomain_vpc (2895.69s)
=== RUN   TestAccAWSElasticSearchDomain_update
--- PASS: TestAccAWSElasticSearchDomain_update (3323.74s)
=== RUN   TestAccAWSElasticSearchDomain_internetToVpcEndpoint
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (3478.52s)
=== RUN   TestAccAWSElasticSearchDomain_CognitoOptionsUpdate
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (3718.78s)
=== RUN   TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (3796.38s)
=== RUN   TestAccAWSElasticSearchDomain_vpc_update
--- FAIL: TestAccAWSElasticSearchDomain_vpc_update (4342.61s)
=== RUN   TestAccAWSElasticSearchDomain_withDedicatedMaster
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (4367.52s)
=== RUN   TestAccAWSElasticSearchDomain_update_volume_type
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (5020.74s)

[bflad]

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!