Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move inputs off heap with autofix: b, t, and v services #41348

Merged
merged 10 commits into from
Feb 13, 2025
Merged

Move inputs off heap with autofix: b, t, and v services #41348

merged 10 commits into from
Feb 13, 2025

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 11, 2025 •
edited
Loading

Description

Allocates inputs on stack for those declared inline to the operation for b, t, and v services.

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/budgets Issues and PRs that pertain to the budgets service. service/batch Issues and PRs that pertain to the batch service. service/backup Issues and PRs that pertain to the backup service. linter Pertains to changes to or issues with the various linters. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 11, 2025
@gdavison gdavison changed the title Move inputs off heap with autofix: b and v services Move inputs off heap with autofix: b, t, and v services Feb 11, 2025
@gdavison gdavison marked this pull request as ready for review February 12, 2025 19:08
@gdavison gdavison requested a review from a team as a code owner February 12, 2025 19:08
@gdavison gdavison enabled auto-merge February 12, 2025 19:50
@gdavison gdavison force-pushed the td-inputs-in-heap-b branch from 6bf4e01 to 66778c3 Compare February 13, 2025 00:17
@gdavison gdavison disabled auto-merge February 13, 2025 00:18
jar-b
jar-b approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit f8efaa5 into main Feb 13, 2025
38 checks passed
@gdavison gdavison deleted the td-inputs-in-heap-b branch February 13, 2025 19:04
@github-actions github-actions bot added this to the v5.87.0 milestone Feb 13, 2025
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.87.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. linter Pertains to changes to or issues with the various linters. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/budgets Issues and PRs that pertain to the budgets service. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.87.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @jar-b