Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_sqs_queue and aws_sqs_queue_policy: Add warning and clean up docs #41249

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 5, 2025

Description

Relations

Closes #29497

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@YakDriver YakDriver requested a review from a team as a code owner February 5, 2025 16:58
Copy link

github-actions bot commented Feb 5, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/sqs Issues and PRs that pertain to the sqs service. labels Feb 5, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 5, 2025
@YakDriver YakDriver changed the title Add warning and clean docs aws_sqs_queue and aws_sqs_queue_policy: Add warning and clean up docs Feb 5, 2025
website/docs/r/sqs_queue.html.markdown Outdated Show resolved Hide resolved
website/docs/r/sqs_queue_policy.html.markdown Outdated Show resolved Hide resolved
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Nice cleanup!

@YakDriver YakDriver merged commit 3174d23 into main Feb 5, 2025
22 checks passed
@YakDriver YakDriver deleted the d-sqs-queue-policy branch February 5, 2025 18:19
@github-actions github-actions bot added this to the v5.86.0 milestone Feb 5, 2025
Copy link

github-actions bot commented Feb 6, 2025

This functionality has been released in v5.86.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/sqs Issues and PRs that pertain to the sqs service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Timeout when creating/updating sqs_queue_policy without policy Version
2 participants