Tech debt: Isolate AWS SDK for Go v1 references

[ewbankkit]

Description

From July 31 2024 the AWS SDK for Go v1 has been placed in maintenance mode, meaning that the SDK receives only critical bug and security fixes and does not receive API updates for services or support for new AWS Regions. One year later, as of July 31 2025, the SDK will be at end-of-support, with no further updates.
The Terraform AWS Provider has steadily been migrating to the fully supported AWS SDK for Go v2, and thanks to sustained community contributions, at the time of writing (mid-October 2024) migration of resources and data sources for all bar 1 service has been completed. The outstanding migration is the Simple DB service – there is no support in AWS SDK for Go v2 although AWS reports continued usage of the service. We intend to drop support for the aws_simpledb_domain resource at the next major version (v6.0.0) of the Terraform AWS Provider.
The effective completion of the migration allows us to clean up traces of AWS SDK for Go v1 support from all parts of the provider except the internal/conns and internal/service/simpledb packages.

Relations

Relates #32976.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 360m
2024/10/21 14:00:52 Initializing Terraform AWS Provider...
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (11.22s)
--- PASS: TestAccSimpleDBDomain_basic (12.92s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (27.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	32.487s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

Nice to have this isolated so cleanly!

% make testacc PKG=simpledb TESTS=TestAccSimpleDBDomain_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/simpledb/... -v -count 1 -parallel 20 -run='TestAccSimpleDBDomain_'  -timeout 360m

--- PASS: TestAccSimpleDBDomain_disappears (12.28s)
--- PASS: TestAccSimpleDBDomain_basic (14.15s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (24.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/simpledb   29.479s

[gdavison]

Looks good! 🚀

A couple spots where we can stop explicitly indicating something is SDKv2 related

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.