Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ec2_transit_gateway_vpc_attachment: Prevent drift for existing resources #39519

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 27, 2024

Description

Marks security_group_referencing_support as Computed to prevent plan drift for resources created prior to v5.69.0.

Relations

Closes #39518.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencing\|TestAccTransitGateway_serial/VpcAttachment_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencing\|TestAccTransitGateway_serial/VpcAttachment_basic -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencingSupportV5690Diff
=== RUN   TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencingSupportExistingResource
=== RUN   TestAccTransitGateway_serial/VpcAttachment_basic
=== PAUSE TestAccTransitGateway_serial/VpcAttachment_basic
=== RUN   TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencingSupport
=== CONT  TestAccTransitGateway_serial/VpcAttachment_basic
--- PASS: TestAccTransitGateway_serial (1051.85s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencingSupportV5690Diff (362.28s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencingSupportExistingResource (378.81s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachment_SecurityGroupReferencingSupport (310.76s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachment_basic (310.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1368.213s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/VpcAttachmentAccepter_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/VpcAttachmentAccepter_basic -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/VpcAttachmentAccepter_basic
=== PAUSE TestAccTransitGateway_serial/VpcAttachmentAccepter_basic
=== CONT  TestAccTransitGateway_serial/VpcAttachmentAccepter_basic
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachmentAccepter_basic (347.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	353.265s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/Gateway_SecurityGroupReferencingSupport\|TestAccTransitGateway_serial/Gateway_basic' PKG=ec2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/Gateway_SecurityGroupReferencingSupport\|TestAccTransitGateway_serial/Gateway_basic -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/Gateway_SecurityGroupReferencingSupportExistingResource
=== RUN   TestAccTransitGateway_serial/Gateway_SecurityGroupReferencingSupport
=== RUN   TestAccTransitGateway_serial/Gateway_basic
=== PAUSE TestAccTransitGateway_serial/Gateway_basic
=== CONT  TestAccTransitGateway_serial/Gateway_basic
--- PASS: TestAccTransitGateway_serial (449.18s)
    --- PASS: TestAccTransitGateway_serial/Gateway_SecurityGroupReferencingSupportExistingResource (232.41s)
    --- PASS: TestAccTransitGateway_serial/Gateway_SecurityGroupReferencingSupport (216.77s)
    --- PASS: TestAccTransitGateway_serial/Gateway_basic (130.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	585.513s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transitgateway Issues and PRs that pertain to the transitgateway service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 27, 2024
@ewbankkit ewbankkit marked this pull request as ready for review September 27, 2024 16:42
@ewbankkit ewbankkit requested a review from a team as a code owner September 27, 2024 16:42
@ewbankkit
Copy link
Contributor Author

% make golangci-lint PKG=ec2
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
make: golangci-lint Checks / 3 of 3...

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit assigned ewbankkit and unassigned ewbankkit Sep 27, 2024
@ewbankkit ewbankkit merged commit a0a3b9b into main Sep 27, 2024
52 of 53 checks passed
@ewbankkit ewbankkit deleted the b-tgw.security_group_referencing_support branch September 27, 2024 19:51
@github-actions github-actions bot added this to the v5.70.0 milestone Sep 27, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 27, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/transitgateway Issues and PRs that pertain to the transitgateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants