Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_iam_user_login_profile: Fix password_length ValidateFunc #3919

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 26, 2018

Fixes #3912 which was introduced by #3702 in the v1.12.0 release of the AWS provider.

Before code fix:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSUserLoginProfile_PasswordLength'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSUserLoginProfile_PasswordLength -timeout 120m
=== RUN   TestAccAWSUserLoginProfile_PasswordLength
--- FAIL: TestAccAWSUserLoginProfile_PasswordLength (1.70s)
	testing.go:518: Step 0 error: config is invalid: aws_iam_user_login_profile.user: expected type of password_length to be string
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1.741s
make: *** [testacc] Error 1

After code fix:

5 tests passed (all tests)
grep -E -e '^=== RUN' -e '^--- (FAIL|PASS):' ~/Downloads/AWS_Provider_-_*.log; rm -f ~/Downloads/AWS_Provider_-_*.log
=== RUN   TestAccAWSUserLoginProfile_keybaseDoesntExist
--- PASS: TestAccAWSUserLoginProfile_keybaseDoesntExist (9.33s)
=== RUN   TestAccAWSUserLoginProfile_notAKey
--- PASS: TestAccAWSUserLoginProfile_notAKey (9.33s)
=== RUN   TestAccAWSUserLoginProfile_PasswordLength
--- PASS: TestAccAWSUserLoginProfile_PasswordLength (13.05s)
=== RUN   TestAccAWSUserLoginProfile_keybase
--- PASS: TestAccAWSUserLoginProfile_keybase (13.50s)
=== RUN   TestAccAWSUserLoginProfile_basic
--- PASS: TestAccAWSUserLoginProfile_basic (21.08s)

@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/iam Issues and PRs that pertain to the iam service. labels Mar 26, 2018
@bflad bflad added this to the v1.13.0 milestone Mar 26, 2018
@bflad bflad requested a review from a team March 26, 2018 15:26
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Mar 26, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit d692350 into master Mar 26, 2018
@bflad bflad deleted the b-aws_iam_user_login_profile-pwlen-regression branch March 26, 2018 16:37
bflad added a commit that referenced this pull request Mar 26, 2018
@bflad
Copy link
Contributor Author

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iam_user_login_profile - The validation function validates a string length for an integer.
2 participants