Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Route 53 Resolver resources to AWS SDK V2 #38813

Merged
merged 36 commits into from
Aug 13, 2024
Merged

Migrate Route 53 Resolver resources to AWS SDK V2 #38813

merged 36 commits into from
Aug 13, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Aug 9, 2024 •
edited
Loading

Description

This PR migrates the Route 53 Resolver resources to AWS SDKv2.

Relations

Closes #36206
Relates #32976

References

Output from Acceptance Testing

Currently running tests

% make testacc TESTARGS='-run=TestAcc' PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/route53resolver/... -v -count 1 -parallel 3  -run=TestAcc -timeout 360m
--- PASS: TestAccRoute53ResolverFirewallConfigDataSource_basic (20.28s)
--- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (101.80s)
--- PASS: TestAccRoute53ResolverRuleGroupAssociationDataSource_basic (128.15s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroupDataSource_basic (12.88s)
--- PASS: TestAccRoute53ResolverFirewallDomainList_disappears (56.94s)
--- PASS: TestAccRoute53ResolverFirewallRule_qType (60.13s)
--- PASS: TestAccRoute53ResolverEndpoint_tags (163.14s)
--- PASS: TestAccRoute53ResolverFirewallDomainList_domains (212.59s)
--- PASS: TestAccRoute53ResolverFirewallDomainList_basic (59.90s)
--- PASS: TestAccRoute53ResolverFirewallConfig_disappears (20.36s)
--- PASS: TestAccRoute53ResolverFirewallConfig_basic (22.97s)
--- PASS: TestAccRoute53ResolverConfig_basic (354.88s)
--- PASS: TestAccRoute53ResolverEndpoint_resolverEndpointType (149.46s)
--- PASS: TestAccRoute53ResolverEndpointDataSource_basic (97.89s)
--- PASS: TestAccRoute53ResolverEndpoint_disappears (97.50s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_basic (15.11s)
--- PASS: TestAccRoute53ResolverFirewallRule_blockOverride (60.18s)
--- PASS: TestAccRoute53ResolverFirewallRule_block (60.16s)
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (384.32s)
--- PASS: TestAccRoute53ResolverEndpointDataSource_filter (251.53s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_tags (33.83s)
--- PASS: TestAccRoute53ResolverFirewallRule_update_firewallDomainRedirectionAction (69.82s)
--- PASS: TestAccRoute53ResolverFirewallRule_basic (60.30s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_disappears (12.62s)
--- PASS: TestAccRoute53ResolverConfig_Disappears_vpc (19.37s)
--- PASS: TestAccRoute53ResolverEndpoint_basic (90.65s)
=== CONT  TestAccRoute53ResolverRuleDataSource_sharedByMe
    rule_data_source_test.go:119: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ResolverRuleDataSource_sharedByMe (0.00s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (154.44s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex (9.21s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nameRegex (13.44s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_tags (178.63s)
--- PASS: TestAccRoute53ResolverDNSSECConfig_basic (335.74s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_disappears (148.81s)
--- PASS: TestAccRoute53ResolverRulesDataSource_resolverEndpointID (263.54s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_priority (229.53s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_basic (151.15s)
--- PASS: TestAccRoute53ResolverFirewallDomainList_tags (79.57s)
--- PASS: TestAccRoute53ResolverDNSSECConfig_disappear (332.71s)
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_name (266.36s)
--- PASS: TestAccRoute53ResolverQueryLogConfig_disappears (22.83s)
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (303.82s)
--- PASS: TestAccRoute53ResolverRulesDataSource_basic (9.09s)
--- PASS: TestAccRoute53ResolverRule_disappears (12.85s)
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate (514.42s)
--- PASS: TestAccRoute53ResolverRule_basic (15.60s)
--- PASS: TestAccRoute53ResolverRuleAssociation_disappears (201.94s)
=== CONT  TestAccRoute53ResolverRuleDataSource_sharedWithMe
    rule_data_source_test.go:157: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ResolverRuleDataSource_sharedWithMe (0.00s)
--- PASS: TestAccRoute53ResolverQueryLogConfigAssociation_disappears (32.57s)
--- PASS: TestAccRoute53ResolverRuleAssociation_basic (193.66s)
--- PASS: TestAccRoute53ResolverRule_forward (388.93s)
--- PASS: TestAccRoute53ResolverQueryLogConfig_basic (25.25s)
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_filter (16.69s)
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_basic (16.67s)
--- PASS: TestAccRoute53ResolverQueryLogConfigAssociation_basic (34.68s)
--- PASS: TestAccRoute53ResolverFirewallRule_disappears (58.06s)
--- PASS: TestAccRoute53ResolverRule_trailingDotDomainName (15.64s)
--- PASS: TestAccRoute53ResolverFirewallRulesDataSource_basic (139.14s)
--- PASS: TestAccRoute53ResolverRule_updateName (24.95s)
--- PASS: TestAccRoute53ResolverRuleDataSource_basic (13.68s)
--- PASS: TestAccRoute53ResolverRule_justDotDomainName (15.46s)
--- PASS: TestAccRoute53ResolverRule_tags (34.26s)
--- PASS: TestAccRoute53ResolverQueryLogConfig_tags (41.64s)
--- PASS: TestAccRoute53ResolverRuleAssociation_Disappears_vpc (190.99s)
--- PASS: TestAccRoute53ResolverRuleDataSource_resolverEndpointIdWithTags (262.91s)
PASS
ok   	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	2794.249s

@DanielRieske
feat: migrated r/config to sdkv2
5e19735
@DanielRieske
feat: migrated r/dnssec_config to sdkv2
35d5e8c
@DanielRieske
feat: migrated r/endpoint to sdkv2
cce630d
@DanielRieske
feat: migrated d/endpoint to sdkv2
02549cb
@DanielRieske
feat: migrated r/firewall_config to sdkv2
fb79cab
@DanielRieske
feat: migrated d/firewall_config to sdkv2
93ecc65
@DanielRieske
feat: migrated r/firewall_domain_list to sdkv2
7188706
@DanielRieske
feat: migrated r/firewall_rule_group_association to sdkv2
8599765
@DanielRieske
feat: migrated d/firewall_rule_group_association to sdkv2
180693f
@DanielRieske
feat: migrated r/firewall_rule_group to sdkv2
756c025
@DanielRieske
feat: migrated d/firewall_domain_list to sdkv2
8f4fadc
@DanielRieske
feat: migrated d/firewall_rule_group to sdkv2
38b8525
@DanielRieske
feat: migrated r/query_log_config_association to sdkv2
c2dbedc
@DanielRieske
feat: migrated r/query_log_config to sdkv2
1441737
@DanielRieske
feat: migrated r/firewall_rule to sdkv2
957d44d
@DanielRieske
feat: migrated r/rule_association to sdkv2
a8d2b78
@DanielRieske
feat: migrated r/rule to sdkv2
c226454
@DanielRieske
feat: migrated d/query_log_config to sdkv2
549687e
@DanielRieske
feat: migrated d/firewall_rules to sdkv2
435801b
@DanielRieske
feat: regenerate namevaluesfilters
dffc341
@DanielRieske
feat: migrate d/rule to sdkv2
00ba1a9
@DanielRieske
feat: migrate d/rules to sdkv2
9bad262
@DanielRieske
feat: migrate sweepers to sdkv2
cde1684
@DanielRieske
feat: regenerate v2 client
875f507
@DanielRieske
feat: exports
3c8af72
@DanielRieske
feat remove validation on computed field
d5910d9
@DanielRieske DanielRieske requested a review from a team as a code owner August 9, 2024 22:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Aug 9, 2024
@github-actions github-actions bot added service/route53resolver Issues and PRs that pertain to the route53resolver service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 9, 2024
@ewbankkit ewbankkit added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 12, 2024
@ewbankkit ewbankkit self-assigned this Aug 13, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 13, 2024
ewbankkit
ewbankkit approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53Resolver' PKG=route53resolver ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/route53resolver/... -v -count 1 -parallel 3  -run=TestAccRoute53Resolver -timeout 360m
=== RUN   TestAccRoute53ResolverConfig_basic
=== PAUSE TestAccRoute53ResolverConfig_basic
=== RUN   TestAccRoute53ResolverConfig_Disappears_vpc
=== PAUSE TestAccRoute53ResolverConfig_Disappears_vpc
=== RUN   TestAccRoute53ResolverDNSSECConfig_basic
=== PAUSE TestAccRoute53ResolverDNSSECConfig_basic
=== RUN   TestAccRoute53ResolverDNSSECConfig_disappear
=== PAUSE TestAccRoute53ResolverDNSSECConfig_disappear
=== RUN   TestAccRoute53ResolverEndpointDataSource_basic
=== PAUSE TestAccRoute53ResolverEndpointDataSource_basic
=== RUN   TestAccRoute53ResolverEndpointDataSource_filter
=== PAUSE TestAccRoute53ResolverEndpointDataSource_filter
=== RUN   TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN   TestAccRoute53ResolverEndpoint_disappears
=== PAUSE TestAccRoute53ResolverEndpoint_disappears
=== RUN   TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN   TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== RUN   TestAccRoute53ResolverEndpoint_resolverEndpointType
=== PAUSE TestAccRoute53ResolverEndpoint_resolverEndpointType
=== RUN   TestAccRoute53ResolverFirewallConfigDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallConfigDataSource_basic (17.65s)
=== RUN   TestAccRoute53ResolverFirewallConfig_basic
=== PAUSE TestAccRoute53ResolverFirewallConfig_basic
=== RUN   TestAccRoute53ResolverFirewallConfig_disappears
=== PAUSE TestAccRoute53ResolverFirewallConfig_disappears
=== RUN   TestAccRoute53ResolverFirewallDomainListDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (96.65s)
=== RUN   TestAccRoute53ResolverFirewallDomainList_basic
=== PAUSE TestAccRoute53ResolverFirewallDomainList_basic
=== RUN   TestAccRoute53ResolverFirewallDomainList_domains
=== PAUSE TestAccRoute53ResolverFirewallDomainList_domains
=== RUN   TestAccRoute53ResolverFirewallDomainList_disappears
=== PAUSE TestAccRoute53ResolverFirewallDomainList_disappears
=== RUN   TestAccRoute53ResolverFirewallDomainList_tags
=== PAUSE TestAccRoute53ResolverFirewallDomainList_tags
=== RUN   TestAccRoute53ResolverRuleGroupAssociationDataSource_basic
--- PASS: TestAccRoute53ResolverRuleGroupAssociationDataSource_basic (153.59s)
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_name
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_name
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_priority
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_priority
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_disappears
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_disappears
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_tags
=== RUN   TestAccRoute53ResolverFirewallRuleGroupDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroupDataSource_basic (9.44s)
=== RUN   TestAccRoute53ResolverFirewallRuleGroup_basic
=== PAUSE TestAccRoute53ResolverFirewallRuleGroup_basic
=== RUN   TestAccRoute53ResolverFirewallRuleGroup_disappears
=== PAUSE TestAccRoute53ResolverFirewallRuleGroup_disappears
=== RUN   TestAccRoute53ResolverFirewallRuleGroup_tags
=== PAUSE TestAccRoute53ResolverFirewallRuleGroup_tags
=== RUN   TestAccRoute53ResolverFirewallRule_basic
=== PAUSE TestAccRoute53ResolverFirewallRule_basic
=== RUN   TestAccRoute53ResolverFirewallRule_update_firewallDomainRedirectionAction
=== PAUSE TestAccRoute53ResolverFirewallRule_update_firewallDomainRedirectionAction
=== RUN   TestAccRoute53ResolverFirewallRule_block
=== PAUSE TestAccRoute53ResolverFirewallRule_block
=== RUN   TestAccRoute53ResolverFirewallRule_blockOverride
=== PAUSE TestAccRoute53ResolverFirewallRule_blockOverride
=== RUN   TestAccRoute53ResolverFirewallRule_qType
=== PAUSE TestAccRoute53ResolverFirewallRule_qType
=== RUN   TestAccRoute53ResolverFirewallRule_disappears
=== PAUSE TestAccRoute53ResolverFirewallRule_disappears
=== RUN   TestAccRoute53ResolverFirewallRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverFirewallRulesDataSource_basic
=== RUN   TestAccRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccRoute53ResolverQueryLogConfigAssociation_disappears
=== PAUSE TestAccRoute53ResolverQueryLogConfigAssociation_disappears
=== RUN   TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== RUN   TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== RUN   TestAccRoute53ResolverQueryLogConfig_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfig_basic
=== RUN   TestAccRoute53ResolverQueryLogConfig_disappears
=== PAUSE TestAccRoute53ResolverQueryLogConfig_disappears
=== RUN   TestAccRoute53ResolverQueryLogConfig_tags
=== PAUSE TestAccRoute53ResolverQueryLogConfig_tags
=== RUN   TestAccRoute53ResolverRuleAssociation_basic
=== PAUSE TestAccRoute53ResolverRuleAssociation_basic
=== RUN   TestAccRoute53ResolverRuleAssociation_disappears
=== PAUSE TestAccRoute53ResolverRuleAssociation_disappears
=== RUN   TestAccRoute53ResolverRuleAssociation_Disappears_vpc
=== PAUSE TestAccRoute53ResolverRuleAssociation_Disappears_vpc
=== RUN   TestAccRoute53ResolverRuleDataSource_basic
=== PAUSE TestAccRoute53ResolverRuleDataSource_basic
=== RUN   TestAccRoute53ResolverRuleDataSource_resolverEndpointIdWithTags
=== PAUSE TestAccRoute53ResolverRuleDataSource_resolverEndpointIdWithTags
=== RUN   TestAccRoute53ResolverRuleDataSource_sharedByMe
=== PAUSE TestAccRoute53ResolverRuleDataSource_sharedByMe
=== RUN   TestAccRoute53ResolverRuleDataSource_sharedWithMe
=== PAUSE TestAccRoute53ResolverRuleDataSource_sharedWithMe
=== RUN   TestAccRoute53ResolverRule_basic
=== PAUSE TestAccRoute53ResolverRule_basic
=== RUN   TestAccRoute53ResolverRule_disappears
=== PAUSE TestAccRoute53ResolverRule_disappears
=== RUN   TestAccRoute53ResolverRule_tags
=== PAUSE TestAccRoute53ResolverRule_tags
=== RUN   TestAccRoute53ResolverRule_justDotDomainName
=== PAUSE TestAccRoute53ResolverRule_justDotDomainName
=== RUN   TestAccRoute53ResolverRule_trailingDotDomainName
=== PAUSE TestAccRoute53ResolverRule_trailingDotDomainName
=== RUN   TestAccRoute53ResolverRule_updateName
=== PAUSE TestAccRoute53ResolverRule_updateName
=== RUN   TestAccRoute53ResolverRule_forward
=== PAUSE TestAccRoute53ResolverRule_forward
=== RUN   TestAccRoute53ResolverRule_forwardMultiProtocol
=== PAUSE TestAccRoute53ResolverRule_forwardMultiProtocol
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate
=== RUN   TestAccRoute53ResolverRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverRulesDataSource_basic
=== RUN   TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== PAUSE TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== RUN   TestAccRoute53ResolverRulesDataSource_nameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nameRegex
=== RUN   TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== CONT  TestAccRoute53ResolverConfig_basic
=== CONT  TestAccRoute53ResolverFirewallRule_qType
=== CONT  TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
--- PASS: TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex (6.75s)
=== CONT  TestAccRoute53ResolverRulesDataSource_nameRegex
--- PASS: TestAccRoute53ResolverRulesDataSource_nameRegex (9.53s)
=== CONT  TestAccRoute53ResolverRulesDataSource_resolverEndpointID
--- PASS: TestAccRoute53ResolverFirewallRule_qType (54.92s)
=== CONT  TestAccRoute53ResolverRulesDataSource_basic
--- PASS: TestAccRoute53ResolverRulesDataSource_basic (6.70s)
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate
--- PASS: TestAccRoute53ResolverRulesDataSource_resolverEndpointID (252.29s)
=== CONT  TestAccRoute53ResolverRule_forwardMultiProtocol
--- PASS: TestAccRoute53ResolverConfig_basic (331.83s)
=== CONT  TestAccRoute53ResolverRule_forward
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate (509.47s)
=== CONT  TestAccRoute53ResolverRule_updateName
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (314.99s)
=== CONT  TestAccRoute53ResolverRule_trailingDotDomainName
--- PASS: TestAccRoute53ResolverRule_updateName (18.81s)
=== CONT  TestAccRoute53ResolverRule_justDotDomainName
--- PASS: TestAccRoute53ResolverRule_trailingDotDomainName (11.41s)
=== CONT  TestAccRoute53ResolverRule_tags
--- PASS: TestAccRoute53ResolverRule_justDotDomainName (11.25s)
=== CONT  TestAccRoute53ResolverQueryLogConfig_tags
--- PASS: TestAccRoute53ResolverRule_tags (24.95s)
=== CONT  TestAccRoute53ResolverQueryLogConfig_disappears
--- PASS: TestAccRoute53ResolverRule_forward (290.30s)
=== CONT  TestAccRoute53ResolverQueryLogConfig_basic
--- PASS: TestAccRoute53ResolverQueryLogConfig_tags (29.79s)
=== CONT  TestAccRoute53ResolverQueryLogConfigDataSource_filter
--- PASS: TestAccRoute53ResolverQueryLogConfig_disappears (16.15s)
=== CONT  TestAccRoute53ResolverQueryLogConfigDataSource_basic
--- PASS: TestAccRoute53ResolverQueryLogConfig_basic (18.54s)
=== CONT  TestAccRoute53ResolverQueryLogConfigAssociation_disappears
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_filter (12.10s)
=== CONT  TestAccRoute53ResolverRuleAssociation_basic
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_basic (12.48s)
=== CONT  TestAccRoute53ResolverQueryLogConfigAssociation_basic
--- PASS: TestAccRoute53ResolverQueryLogConfigAssociation_disappears (27.91s)
=== CONT  TestAccRoute53ResolverRule_disappears
--- PASS: TestAccRoute53ResolverQueryLogConfigAssociation_basic (28.81s)
=== CONT  TestAccRoute53ResolverFirewallRulesDataSource_basic
--- PASS: TestAccRoute53ResolverRule_disappears (9.62s)
=== CONT  TestAccRoute53ResolverRule_basic
--- PASS: TestAccRoute53ResolverRule_basic (11.86s)
=== CONT  TestAccRoute53ResolverFirewallRule_disappears
--- PASS: TestAccRoute53ResolverFirewallRule_disappears (54.46s)
=== CONT  TestAccRoute53ResolverRuleDataSource_sharedWithMe
    rule_data_source_test.go:157: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ResolverRuleDataSource_sharedWithMe (0.00s)
=== CONT  TestAccRoute53ResolverRuleDataSource_sharedByMe
    rule_data_source_test.go:119: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ResolverRuleDataSource_sharedByMe (0.00s)
=== CONT  TestAccRoute53ResolverRuleDataSource_resolverEndpointIdWithTags
--- PASS: TestAccRoute53ResolverFirewallRulesDataSource_basic (127.02s)
=== CONT  TestAccRoute53ResolverRuleDataSource_basic
--- PASS: TestAccRoute53ResolverRuleDataSource_basic (11.27s)
=== CONT  TestAccRoute53ResolverRuleAssociation_Disappears_vpc
--- PASS: TestAccRoute53ResolverRuleAssociation_basic (208.13s)
=== CONT  TestAccRoute53ResolverRuleAssociation_disappears
--- PASS: TestAccRoute53ResolverRuleDataSource_resolverEndpointIdWithTags (254.16s)
=== CONT  TestAccRoute53ResolverEndpoint_tags
--- PASS: TestAccRoute53ResolverRuleAssociation_Disappears_vpc (205.66s)
=== CONT  TestAccRoute53ResolverFirewallDomainList_disappears
--- PASS: TestAccRoute53ResolverRuleAssociation_disappears (196.52s)
=== CONT  TestAccRoute53ResolverFirewallRule_blockOverride
--- PASS: TestAccRoute53ResolverFirewallDomainList_disappears (52.93s)
=== CONT  TestAccRoute53ResolverFirewallDomainList_domains
--- PASS: TestAccRoute53ResolverFirewallRule_blockOverride (55.33s)
=== CONT  TestAccRoute53ResolverFirewallRule_block
--- PASS: TestAccRoute53ResolverFirewallRule_block (55.61s)
=== CONT  TestAccRoute53ResolverFirewallRule_update_firewallDomainRedirectionAction
--- PASS: TestAccRoute53ResolverFirewallRule_update_firewallDomainRedirectionAction (62.87s)
=== CONT  TestAccRoute53ResolverFirewallDomainList_basic
--- PASS: TestAccRoute53ResolverEndpoint_tags (237.39s)
=== CONT  TestAccRoute53ResolverFirewallRule_basic
--- PASS: TestAccRoute53ResolverFirewallDomainList_domains (200.52s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroup_tags
--- PASS: TestAccRoute53ResolverFirewallDomainList_basic (54.96s)
=== CONT  TestAccRoute53ResolverFirewallConfig_disappears
--- PASS: TestAccRoute53ResolverFirewallRule_basic (55.22s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroup_disappears
--- PASS: TestAccRoute53ResolverFirewallConfig_disappears (20.98s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroup_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_tags (24.86s)
=== CONT  TestAccRoute53ResolverFirewallConfig_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_disappears (9.53s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_tags
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_basic (11.08s)
=== CONT  TestAccRoute53ResolverEndpoint_resolverEndpointType
--- PASS: TestAccRoute53ResolverFirewallConfig_basic (22.18s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_disappears
--- PASS: TestAccRoute53ResolverEndpoint_resolverEndpointType (135.86s)
=== CONT  TestAccRoute53ResolverEndpoint_updateOutbound
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_disappears (142.02s)
=== CONT  TestAccRoute53ResolverEndpointDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_tags (172.32s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_priority
--- PASS: TestAccRoute53ResolverEndpointDataSource_basic (90.02s)
=== CONT  TestAccRoute53ResolverEndpoint_disappears
--- PASS: TestAccRoute53ResolverEndpoint_disappears (90.51s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_priority (218.08s)
=== CONT  TestAccRoute53ResolverEndpoint_basic
--- PASS: TestAccRoute53ResolverEndpoint_basic (92.86s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_name
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (164.22s)
=== CONT  TestAccRoute53ResolverEndpointDataSource_filter
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (400.31s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_basic (154.26s)
=== CONT  TestAccRoute53ResolverFirewallDomainList_tags
--- PASS: TestAccRoute53ResolverFirewallDomainList_tags (69.36s)
=== CONT  TestAccRoute53ResolverDNSSECConfig_basic
--- PASS: TestAccRoute53ResolverEndpointDataSource_filter (263.71s)
=== CONT  TestAccRoute53ResolverDNSSECConfig_disappear
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_name (303.08s)
=== CONT  TestAccRoute53ResolverConfig_Disappears_vpc
--- PASS: TestAccRoute53ResolverConfig_Disappears_vpc (14.15s)
--- PASS: TestAccRoute53ResolverDNSSECConfig_basic (327.40s)
--- PASS: TestAccRoute53ResolverDNSSECConfig_disappear (325.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	2672.523s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2aceccc into hashicorp:main Aug 13, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 13, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/route53resolver Issues and PRs that pertain to the route53resolver service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.63.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Route 53 Resolver Service
2 participants
@DanielRieske @ewbankkit