-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Route 53 Recovery Control Config
resources to AWS SDK V2
#38777
Migrate Route 53 Recovery Control Config
resources to AWS SDK V2
#38777
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53RecoveryControlConfig_serial' PKG=route53recoverycontrolconfig
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/route53recoverycontrolconfig/... -v -count 1 -parallel 20 -run=TestAccRoute53RecoveryControlConfig_serial -timeout 360m
=== RUN TestAccRoute53RecoveryControlConfig_serial
=== PAUSE TestAccRoute53RecoveryControlConfig_serial
=== CONT TestAccRoute53RecoveryControlConfig_serial
=== RUN TestAccRoute53RecoveryControlConfig_serial/Cluster
=== RUN TestAccRoute53RecoveryControlConfig_serial/Cluster/disappears
=== RUN TestAccRoute53RecoveryControlConfig_serial/Cluster/basic
=== RUN TestAccRoute53RecoveryControlConfig_serial/ControlPanel
=== RUN TestAccRoute53RecoveryControlConfig_serial/ControlPanel/basic
=== RUN TestAccRoute53RecoveryControlConfig_serial/ControlPanel/disappears
=== RUN TestAccRoute53RecoveryControlConfig_serial/RoutingControl
=== RUN TestAccRoute53RecoveryControlConfig_serial/RoutingControl/basic
=== RUN TestAccRoute53RecoveryControlConfig_serial/RoutingControl/disappears
=== RUN TestAccRoute53RecoveryControlConfig_serial/RoutingControl/nonDefaultControlPane
=== RUN TestAccRoute53RecoveryControlConfig_serial/SafetyRule
=== RUN TestAccRoute53RecoveryControlConfig_serial/SafetyRule/assertionRule
=== RUN TestAccRoute53RecoveryControlConfig_serial/SafetyRule/gatingRule
=== RUN TestAccRoute53RecoveryControlConfig_serial/SafetyRule/disappears
--- PASS: TestAccRoute53RecoveryControlConfig_serial (774.59s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/Cluster (73.04s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/Cluster/disappears (41.36s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/Cluster/basic (31.68s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/ControlPanel (133.91s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/ControlPanel/basic (68.60s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/ControlPanel/disappears (65.31s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/RoutingControl (215.54s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/RoutingControl/basic (72.67s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/RoutingControl/disappears (61.70s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/RoutingControl/nonDefaultControlPane (81.18s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/SafetyRule (352.09s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/SafetyRule/assertionRule (119.24s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/SafetyRule/gatingRule (106.34s)
--- PASS: TestAccRoute53RecoveryControlConfig_serial/SafetyRule/disappears (126.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig 779.640s
@DanielRieske Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR migrates the
Route 53 Recovery Control Config
resources to AWS SDKv2.Relations
Closes #36204
Relates #32976
References
Output from Acceptance Testing