Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags to application resource and datasource #38243

Merged
merged 11 commits into from
Dec 6, 2024
Merged

Add tags to application resource and datasource #38243

merged 11 commits into from
Dec 6, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jul 3, 2024

Description

Add tags to both of these.

Relations

Depends on #38188

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccServiceCatalogAppRegistryApplication PKG=servicecatalogappregistry
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryApplication'  -timeout 360m
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_tags
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_tags
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_null
    application_tags_gen_test.go:190: Tags with null values are not correctly handled with the Plugin Framework
--- SKIP: TestAccServiceCatalogAppRegistryApplication_tags_null (0.00s)
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullOverlappingResourceTag
    application_tags_gen_test.go:1434: Tags with null values are not correctly handled with the Plugin Framework
--- SKIP: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullOverlappingResourceTag (0.00s)
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullNonOverlappingResourceTag
    application_tags_gen_test.go:1497: Tags with null values are not correctly handled with the Plugin Framework
--- SKIP: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullNonOverlappingResourceTag (0.00s)
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccServiceCatalogAppRegistryApplication_basic
=== PAUSE TestAccServiceCatalogAppRegistryApplication_basic
=== RUN   TestAccServiceCatalogAppRegistryApplication_disappears
=== PAUSE TestAccServiceCatalogAppRegistryApplication_disappears
=== RUN   TestAccServiceCatalogAppRegistryApplication_update
=== PAUSE TestAccServiceCatalogAppRegistryApplication_update
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_tags
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccServiceCatalogAppRegistryApplication_disappears
=== CONT  TestAccServiceCatalogAppRegistryApplication_basic
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccServiceCatalogAppRegistryApplication_update
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_tags (38.56s)
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_basic (44.84s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_basic (47.23s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_disappears (48.38s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag (54.62s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate (54.73s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag (54.96s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly (71.81s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate (73.95s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace (74.01s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly (74.35s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate (76.43s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add (76.71s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace (77.12s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_update (84.16s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add (91.48s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping (96.04s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping (96.16s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly (110.33s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags (110.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  114.814s

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. labels Jul 3, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jul 3, 2024
@drewtul drewtul marked this pull request as ready for review July 3, 2024 17:04
@drewtul drewtul requested a review from a team as a code owner July 3, 2024 17:04
@justinretzolk justinretzolk added tags Pertains to resource tagging. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 8, 2024
@drewtul drewtul mentioned this pull request Jul 8, 2024
Merged
@drewtul drewtul force-pushed the f-sc-appregistry-application-updates branch 3 times, most recently from 92a2efa to ade8076 Compare December 5, 2024 22:12
@drewtul drewtul force-pushed the f-sc-appregistry-application-updates branch from ade8076 to a4380a2 Compare December 6, 2024 09:05
@ewbankkit ewbankkit self-assigned this Dec 6, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 6, 2024
ewbankkit
ewbankkit approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalogAppRegistryApplicationDataSource_\|TestAccServiceCatalogAppRegistryApplication_' PKG=servicecatalogappregistry ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 4  -run=TestAccServiceCatalogAppRegistryApplicationDataSource_\|TestAccServiceCatalogAppRegistryApplication_ -timeout 360m
2024/12/06 09:44:15 Initializing Terraform AWS Provider...
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_tags
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_tags
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_tags_NullMap
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_tags_NullMap
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_tags_EmptyMap
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_tags_EmptyMap
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== PAUSE TestAccServiceCatalogAppRegistryApplicationDataSource_basic
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_null
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_null
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_EmptyMap
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_EmptyMap
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccServiceCatalogAppRegistryApplication_basic
=== PAUSE TestAccServiceCatalogAppRegistryApplication_basic
=== RUN   TestAccServiceCatalogAppRegistryApplication_disappears
=== PAUSE TestAccServiceCatalogAppRegistryApplication_disappears
=== RUN   TestAccServiceCatalogAppRegistryApplication_update
=== PAUSE TestAccServiceCatalogAppRegistryApplication_update
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_tags
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_null
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_tags (11.82s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_null (15.05s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyProviderOnlyTag (14.56s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Add (27.74s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnCreate (18.22s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_overlapping (39.17s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullNonOverlappingResourceTag (14.15s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nullOverlappingResourceTag (14.39s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Replace (22.74s)
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnUpdate_Add (34.43s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_DefaultTag (11.49s)
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_basic
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_nonOverlapping (38.24s)
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_tags_IgnoreTags_Overlap_ResourceTag (11.63s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_basic
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_basic (13.11s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_update
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_providerOnly (49.70s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_disappears
--- PASS: TestAccServiceCatalogAppRegistryApplication_disappears (12.32s)
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_tags_NullMap
--- PASS: TestAccServiceCatalogAppRegistryApplication_basic (14.49s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_tags_NullMap (10.85s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags (48.54s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate
--- PASS: TestAccServiceCatalogAppRegistryApplication_update (29.06s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToResourceOnly (21.61s)
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_emptyResourceTag (14.18s)
=== CONT  TestAccServiceCatalogAppRegistryApplicationDataSource_tags_EmptyMap
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_tags_DefaultTags_nonOverlapping (11.60s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccServiceCatalogAppRegistryApplicationDataSource_tags_EmptyMap (11.12s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_AddOnUpdate (22.84s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_EmptyTag_OnCreate (26.14s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_EmptyMap
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_EmptyMap (13.89s)
=== CONT  TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_DefaultTag (28.89s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_ComputedTag_OnUpdate_Replace (26.86s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_IgnoreTags_Overlap_ResourceTag (31.31s)
--- PASS: TestAccServiceCatalogAppRegistryApplication_tags_DefaultTags_updateToProviderOnly (22.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry	186.570s

johnsonaj
johnsonaj approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e7b7dd0 into hashicorp:main Dec 6, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.81.0 milestone Dec 6, 2024
@drewtul drewtul deleted the f-sc-appregistry-application-updates branch December 6, 2024 18:09
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. partner Contribution from a partner. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@drewtul @ewbankkit @johnsonaj @justinretzolk