-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elastictranscoder: Migrate to AWS SDK v2 #38018
elastictranscoder: Migrate to AWS SDK v2 #38018
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…delete ```console % make testacc PKG=elastictranscoder make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/elastictranscoder/... -v -count 1 -parallel 20 -timeout 360m --- PASS: TestEndpointConfiguration (0.66s) --- PASS: TestEndpointConfiguration/no_config (0.03s) --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.04s) --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.04s) --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.03s) --- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.04s) --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.04s) --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.05s) --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.03s) --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.03s) --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.03s) --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.04s) --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.03s) --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.03s) --- PASS: TestEndpointConfiguration/use_fips_config (0.03s) --- PASS: TestEndpointConfiguration/service_aws_envvar (0.03s) --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s) --- PASS: TestEndpointConfiguration/service_config_file (0.03s) --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.03s) === CONT TestAccElasticTranscoderPipeline_basic === CONT TestAccElasticTranscoderPreset_video_noCodec === CONT TestAccElasticTranscoderPipeline_withPermissions === CONT TestAccElasticTranscoderPreset_Video_frameRate === CONT TestAccElasticTranscoderPreset_full === CONT TestAccElasticTranscoderPipeline_notifications === CONT TestAccElasticTranscoderPreset_description === CONT TestAccElasticTranscoderPreset_AudioCodecOptions_empty === CONT TestAccElasticTranscoderPreset_disappears === CONT TestAccElasticTranscoderPreset_audio_noBitRate === CONT TestAccElasticTranscoderPipeline_withContent === CONT TestAccElasticTranscoderPreset_basic === CONT TestAccElasticTranscoderPipeline_kmsKey === CONT TestAccElasticTranscoderPipeline_disappears --- PASS: TestAccElasticTranscoderPreset_disappears (18.36s) --- PASS: TestAccElasticTranscoderPreset_Video_frameRate (21.60s) --- PASS: TestAccElasticTranscoderPreset_description (23.73s) --- PASS: TestAccElasticTranscoderPreset_basic (23.86s) --- PASS: TestAccElasticTranscoderPreset_audio_noBitRate (23.93s) --- PASS: TestAccElasticTranscoderPipeline_disappears (25.19s) --- PASS: TestAccElasticTranscoderPipeline_basic (26.98s) --- PASS: TestAccElasticTranscoderPipeline_withPermissions (28.32s) --- PASS: TestAccElasticTranscoderPreset_AudioCodecOptions_empty (28.55s) --- PASS: TestAccElasticTranscoderPreset_video_noCodec (30.26s) --- PASS: TestAccElasticTranscoderPreset_full (34.48s) --- PASS: TestAccElasticTranscoderPipeline_notifications (37.32s) --- PASS: TestAccElasticTranscoderPipeline_withContent (37.32s) --- PASS: TestAccElasticTranscoderPipeline_kmsKey (48.26s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder 54.746s ```
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc PKG=elastictranscoder
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/elastictranscoder/... -v -count 1 -parallel 20 -timeout 360m
--- PASS: TestEndpointConfiguration (0.66s)
--- PASS: TestEndpointConfiguration/no_config (0.03s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.04s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.04s)
--- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.03s)
--- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.04s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.04s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.05s)
--- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.03s)
--- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.04s)
--- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.03s)
--- PASS: TestEndpointConfiguration/use_fips_config (0.03s)
--- PASS: TestEndpointConfiguration/service_aws_envvar (0.03s)
--- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s)
--- PASS: TestEndpointConfiguration/service_config_file (0.03s)
--- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.03s)
=== CONT TestAccElasticTranscoderPipeline_basic
=== CONT TestAccElasticTranscoderPreset_video_noCodec
=== CONT TestAccElasticTranscoderPipeline_withPermissions
=== CONT TestAccElasticTranscoderPreset_Video_frameRate
=== CONT TestAccElasticTranscoderPreset_full
=== CONT TestAccElasticTranscoderPipeline_notifications
=== CONT TestAccElasticTranscoderPreset_description
=== CONT TestAccElasticTranscoderPreset_AudioCodecOptions_empty
=== CONT TestAccElasticTranscoderPreset_disappears
=== CONT TestAccElasticTranscoderPreset_audio_noBitRate
=== CONT TestAccElasticTranscoderPipeline_withContent
=== CONT TestAccElasticTranscoderPreset_basic
=== CONT TestAccElasticTranscoderPipeline_kmsKey
=== CONT TestAccElasticTranscoderPipeline_disappears
--- PASS: TestAccElasticTranscoderPreset_disappears (18.36s)
--- PASS: TestAccElasticTranscoderPreset_Video_frameRate (21.60s)
--- PASS: TestAccElasticTranscoderPreset_description (23.73s)
--- PASS: TestAccElasticTranscoderPreset_basic (23.86s)
--- PASS: TestAccElasticTranscoderPreset_audio_noBitRate (23.93s)
--- PASS: TestAccElasticTranscoderPipeline_disappears (25.19s)
--- PASS: TestAccElasticTranscoderPipeline_basic (26.98s)
--- PASS: TestAccElasticTranscoderPipeline_withPermissions (28.32s)
--- PASS: TestAccElasticTranscoderPreset_AudioCodecOptions_empty (28.55s)
--- PASS: TestAccElasticTranscoderPreset_video_noCodec (30.26s)
--- PASS: TestAccElasticTranscoderPreset_full (34.48s)
--- PASS: TestAccElasticTranscoderPipeline_notifications (37.32s)
--- PASS: TestAccElasticTranscoderPipeline_withContent (37.32s)
--- PASS: TestAccElasticTranscoderPipeline_kmsKey (48.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder 54.746s
Thanks for your contribution, @mattburgess! 👍 |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36153
Relates #32976
References
Output from Acceptance Testing