Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase limit for maximum concurrent executions beyond 1000 #37980

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
01ec605
Increase limit for maximum concurrent executions beyond 1000
prince310501 Jun 14, 2024
f44af74
Add changelog
prince310501 Jun 17, 2024
4175ce2
Add 'names.EUISOEWest1RegionID'.
ewbankkit Jun 18, 2024
ab67c98
providerlint: Import 'github.com/hashicorp/terraform-provider-aws'.
ewbankkit Jun 18, 2024
dc8d6de
Add 'names.AllRegionIDs'.
ewbankkit Jun 18, 2024
745e3bd
.ci/providerlint: Run 'go get github.com/hashicorp/terraform-provider…
ewbankkit Jun 18, 2024
9e4456f
.ci/providerlint: Run 'go mod vendor'.
ewbankkit Jun 18, 2024
f2be7aa
AWSAT003: Use 'names.AllRegionIDs'.
ewbankkit Jun 18, 2024
325d174
Revert "AWSAT003: Use 'names.AllRegionIDs'."
ewbankkit Jun 18, 2024
c47c2cd
Revert ".ci/providerlint: Run 'go mod vendor'."
ewbankkit Jun 18, 2024
5396d39
Revert ".ci/providerlint: Run 'go get github.com/hashicorp/terraform-…
ewbankkit Jun 18, 2024
40c45c6
Revert "Add 'names.AllRegionIDs'."
ewbankkit Jun 18, 2024
b8ba1ee
Revert "providerlint: Import 'github.com/hashicorp/terraform-provider…
ewbankkit Jun 18, 2024
4957344
Revert "Revert "Add 'names.AllRegionIDs'.""
ewbankkit Jun 18, 2024
eee5aa6
Add 'names.Regions()'.
ewbankkit Jun 18, 2024
4589243
Merge branch 'main' into HEAD
ewbankkit Jun 18, 2024
2ccc5d5
Tweak CHANGELOG entry.
ewbankkit Jun 18, 2024
5e95d1a
Fix markdown-lint 'MD032/blanks-around-lists Lists should be surround…
ewbankkit Jun 18, 2024
3038ea9
Merge commit 'eee5aa6259d0349eeae17ec47e711b3d8780f9fb' into HEAD
ewbankkit Jun 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/37980.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_lambda_event_source_mapping: Remove the upper limit on `scaling_config.maximum_concurrency`
```
2 changes: 1 addition & 1 deletion internal/service/lambda/event_source_mapping.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func resourceEventSourceMapping() *schema.Resource {
"maximum_concurrency": {
Type: schema.TypeInt,
Optional: true,
ValidateFunc: validation.IntBetween(2, 1000),
ValidateFunc: validation.IntAtLeast(2),
},
},
},
Expand Down
50 changes: 50 additions & 0 deletions names/names.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package names
import (
"fmt"
"log"
"slices"
"strings"

"github.com/hashicorp/terraform-provider-aws/names/data"
Expand Down Expand Up @@ -170,8 +171,55 @@ const (

// AWS ISOB (US) partition's regions.
USISOBEast1RegionID = "us-isob-east-1" // US ISOB East (Ohio).

// AWS ISOF partition's regions.
EUISOEWest1RegionID = "eu-isoe-west-1" // EU ISOE West.
)

var allRegionIDs = []string{
AFSouth1RegionID,
APEast1RegionID,
APNortheast1RegionID,
APNortheast2RegionID,
APNortheast3RegionID,
APSouth1RegionID,
APSouth2RegionID,
APSoutheast1RegionID,
APSoutheast2RegionID,
APSoutheast3RegionID,
APSoutheast4RegionID,
CACentral1RegionID,
CAWest1RegionID,
EUCentral1RegionID,
EUCentral2RegionID,
EUNorth1RegionID,
EUSouth1RegionID,
EUSouth2RegionID,
EUWest1RegionID,
EUWest2RegionID,
EUWest3RegionID,
ILCentral1RegionID,
MECentral1RegionID,
MESouth1RegionID,
SAEast1RegionID,
USEast1RegionID,
USEast2RegionID,
USWest1RegionID,
USWest2RegionID,
CNNorth1RegionID,
CNNorthwest1RegionID,
USGovEast1RegionID,
USGovWest1RegionID,
USISOEast1RegionID,
USISOWest1RegionID,
USISOBEast1RegionID,
EUISOEWest1RegionID,
}

func Regions() []string {
return slices.Clone(allRegionIDs)
}

func DNSSuffixForPartition(partition string) string {
switch partition {
case "":
Expand Down Expand Up @@ -218,6 +266,8 @@ func PartitionForRegion(region string) string {
return ISOPartitionID
case USISOBEast1RegionID:
return ISOBPartitionID
case EUISOEWest1RegionID:
return ISOEPartitionID
case USGovEast1RegionID, USGovWest1RegionID:
return USGovCloudPartitionID
default:
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/lambda_event_source_mapping.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ resource "aws_lambda_event_source_mapping" "example" {

### scaling_config Configuration Block

* `maximum_concurrency` - (Optional) Limits the number of concurrent instances that the Amazon SQS event source can invoke. Must be between `2` and `1000`. See [Configuring maximum concurrency for Amazon SQS event sources](https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#events-sqs-max-concurrency).
* `maximum_concurrency` - (Optional) Limits the number of concurrent instances that the Amazon SQS event source can invoke. Must be greater than or equal to `2`. See [Configuring maximum concurrency for Amazon SQS event sources](https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#events-sqs-max-concurrency). You need to raise a [Service Quota Ticket](https://docs.aws.amazon.com/general/latest/gr/aws_service_limits.html) to increase the concurrency beyond 1000.

### self_managed_event_source Configuration Block

Expand Down
Loading