-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Update maximum build_timeout for codebuild from 8 hours to 36 hours #37970
bugfix: Update maximum build_timeout for codebuild from 8 hours to 36 hours #37970
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @WestonReed 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
d68357b
to
d9e8d06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodeBuildProject_buildBatchConfigDelete\|TestAccCodeBuildProject_basic' PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run=TestAccCodeBuildProject_buildBatchConfigDelete\|TestAccCodeBuildProject_basic -timeout 360m
=== RUN TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== CONT TestAccCodeBuildProject_basic
=== CONT TestAccCodeBuildProject_buildBatchConfigDelete
=== NAME TestAccCodeBuildProject_basic
source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_basic (0.31s)
=== NAME TestAccCodeBuildProject_buildBatchConfigDelete
source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildBatchConfigDelete (0.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codebuild 4.614s
@WestonReed Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.54.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The maximum timeout for AWS CodeBuild has been updated to 36 hours (2160 minutes). Update the provider configuration to allow setting values > 480. Currently, trying to set values > 480 will result in the following provider error:
Relations
Fixes #37823
References
Quotas for AWS CodeBuild
Output from Acceptance Testing