Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecs_properties to job_definition of batch #37871

Merged
merged 30 commits into from
Aug 16, 2024
Merged

Add ecs_properties to job_definition of batch #37871

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
a50c27c
add ecs_properties
takaishi Jun 6, 2024
7f0c036
update doc
takaishi Jun 6, 2024
4fab4ef
updated go.mod
takaishi Jun 7, 2024
dbeb786
add validations
takaishi Jun 7, 2024
01b8570
fmt
takaishi Jun 7, 2024
790687d
add properties to test
takaishi Jun 7, 2024
79255d4
add changelog
takaishi Jun 7, 2024
3140deb
Merge remote-tracking branch 'upstream/main' into feat/batch_ecs_prop…
takaishi Jun 27, 2024
4cf8e6e
fix: volumes not volume
takaishi Jun 30, 2024
6a966d7
fix: typo
takaishi Jun 30, 2024
320085f
fix: section title
takaishi Jun 30, 2024
e90348c
fix: containers has a list of container.
takaishi Jun 30, 2024
10a4475
chore: use container instead of containers because task_properties ca…
takaishi Jul 4, 2024
18ce938
doc: add example has multiple containers
takaishi Jul 4, 2024
a2dd13d
Merge remote-tracking branch 'upstream/main' into feat/batch_ecs_prop…
takaishi Jul 4, 2024
f336d32
chore: update go.mod
takaishi Jul 4, 2024
e021160
fix: typo
takaishi Jul 6, 2024
4c61ae1
fix: max size of containers is 10
takaishi Jul 6, 2024
d0469ee
Merge remote-tracking branch 'upstream/main' into feat/batch_ecs_prop…
takaishi Jul 16, 2024
aede86f
Update internal/service/batch/job_definition.go
ewbankkit Aug 15, 2024
1757c41
Merge branch 'main' into HEAD
ewbankkit Aug 15, 2024
3fcbfb5
r/aws_batch_job_definition: Some cleanup for 'ecs_properties'.
ewbankkit Aug 15, 2024
e35c0bd
Add 'TestEquivalentECSPropertiesJSON'.
ewbankkit Aug 15, 2024
d1210d6
Add 'TestAccBatchJobDefinition_ECSProperties_basic'.
ewbankkit Aug 15, 2024
3b37226
r/aws_batch_job_definitions: Fixup normalization of 'ecs_properties'.
ewbankkit Aug 16, 2024
ac79175
Use 'jsoncmp' in unit tests.
ewbankkit Aug 16, 2024
f964e4f
'TestAccBatchJobDefinition_ECSProperties_basic' -> 'TestAccBatchJobDe…
ewbankkit Aug 16, 2024
15a70ad
r/aws_batch_job_definition: Documentation example of 'ecs_properties'.
ewbankkit Aug 16, 2024
4955f8b
Add copyright headers.
ewbankkit Aug 16, 2024
cc5762c
Fix providerlint AWSAT003 & AWSAT005.
ewbankkit Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/37871.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
`release-note:enhancement
resource/aws_batch_job_definition: Adds ability to define `ecs_properties`
```
Loading