-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/hashicorp/terraform-plugin-framework from 1.7.0 to 1.8.0 in the terraform-devex group #36992
Conversation
Community NoteVoting for Prioritization
For Submitters
|
896a2af
to
57db94f
Compare
b8f20b8
to
b1f6063
Compare
func ARNValueMust(value string) ARN { | ||
return fwdiag.Must(ARNValue(value)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that validation is done on the value (during validate
, plan
, or apply
), I opted to remove the Must
variant of any constructors which had one.
There were only a few instances where the ARNValue
constructor was being used at runtime with handling for the returned diagnostics. I replaced those with direct calls to arn.Parse
to guarantee the validity of the ARN value prior to initializing the value. Everywhere ARNValueMust
was used has been replaced with the updated ARNValue
signature that does not return diagnostics.
Bumps the terraform-devex group with 1 update: [github.com/hashicorp/terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework). Updates `github.com/hashicorp/terraform-plugin-framework` from 1.7.0 to 1.8.0 - [Release notes](https://github.com/hashicorp/terraform-plugin-framework/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-framework/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-framework@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-framework dependency-type: direct:production update-type: version-update:semver-minor dependency-group: terraform-devex ... Signed-off-by: dependabot[bot] <[email protected]>
Initialization of a known `ARN` type now can only be done via the `ARNValue` function. The `ARNValueMust` function has been removed, and validation previously applied during initialization has moved into the `ValidateAttribute` method. This change has minimal impact to most existing usages of the initialization functions. In the cases where the diagnostics response from `ARNValue` was being explicitly handled, the `arn.Parse` function has been inserted instead, providing the same effect the init-time validation previously supplied.
b1f6063
to
fa504f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Bumps the terraform-devex group with 1 update: github.com/hashicorp/terraform-plugin-framework.
Updates
github.com/hashicorp/terraform-plugin-framework
from 1.7.0 to 1.8.0Release notes
Sourced from github.com/hashicorp/terraform-plugin-framework's releases.
Changelog
Sourced from github.com/hashicorp/terraform-plugin-framework's changelog.
Commits
711b0a5
Update changelog9d9533c
build(deps): Bump github.com/hashicorp/terraform-plugin-go (#984)23c2403
Remove wildcard suffix fromsetup_terraform
workflow call (#981)392ed7c
website: Update testing documentation to utilize newstatecheck
and `knownv...de32b2c
basetypes: fix equality for values with nil elementType (#961)d36ac87
Add parameter-based provider-defined function validation (#971)f6057df
docs: Remove technical preview verbiage from provider-defined functions (#972)4a9b6a3
Add type-based provider-defined function parameter validation (#968)541a7cb
Small edit for style on a code comment (#975)484f311
internal/fwserver: Ensure computed dynamic values are marked as dynamic type ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions