-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rum: Migrate to AWS SDK v2 #36966
rum: Migrate to AWS SDK v2 #36966
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
26cb588
to
a6a0a87
Compare
# Conflicts: # go.mod # go.sum # internal/conns/awsclient_gen.go # internal/service/rum/app_monitor.go # internal/service/rum/metrics_destination.go # internal/service/rum/service_endpoints_gen_test.go # internal/service/rum/service_package_gen.go # names/data/names_data.csv # names/names.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRUM' PKG=rum ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/rum/... -v -count 1 -parallel 3 -run=TestAccRUM -timeout 360m
=== RUN TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN TestAccRUMAppMonitor_customEvents
=== PAUSE TestAccRUMAppMonitor_customEvents
=== RUN TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== RUN TestAccRUMMetricsDestination_basic
=== PAUSE TestAccRUMMetricsDestination_basic
=== RUN TestAccRUMMetricsDestination_disappears
=== PAUSE TestAccRUMMetricsDestination_disappears
=== RUN TestAccRUMMetricsDestination_disappears_appMonitor
=== PAUSE TestAccRUMMetricsDestination_disappears_appMonitor
=== CONT TestAccRUMAppMonitor_basic
=== CONT TestAccRUMMetricsDestination_basic
=== CONT TestAccRUMMetricsDestination_disappears_appMonitor
--- PASS: TestAccRUMMetricsDestination_disappears_appMonitor (22.89s)
=== CONT TestAccRUMMetricsDestination_disappears
--- PASS: TestAccRUMMetricsDestination_basic (24.53s)
=== CONT TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_basic (38.42s)
=== CONT TestAccRUMAppMonitor_disappears
--- PASS: TestAccRUMMetricsDestination_disappears (18.93s)
=== CONT TestAccRUMAppMonitor_customEvents
--- PASS: TestAccRUMAppMonitor_disappears (17.82s)
--- PASS: TestAccRUMAppMonitor_tags (48.49s)
--- PASS: TestAccRUMAppMonitor_customEvents (48.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rum 95.196s
% make testacc TESTARGS='-run=TestAccVPCNetworkInsights' PKG=ec2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 4 -run=TestAccVPCNetworkInsights -timeout 360m
=== RUN TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== RUN TestAccVPCNetworkInsightsAnalysis_basic
=== PAUSE TestAccVPCNetworkInsightsAnalysis_basic
=== RUN TestAccVPCNetworkInsightsAnalysis_disappears
=== PAUSE TestAccVPCNetworkInsightsAnalysis_disappears
=== RUN TestAccVPCNetworkInsightsAnalysis_tags
=== PAUSE TestAccVPCNetworkInsightsAnalysis_tags
=== RUN TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== PAUSE TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== RUN TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== PAUSE TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== RUN TestAccVPCNetworkInsightsPathDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsPathDataSource_basic
=== RUN TestAccVPCNetworkInsightsPath_basic
=== PAUSE TestAccVPCNetworkInsightsPath_basic
=== RUN TestAccVPCNetworkInsightsPath_disappears
=== PAUSE TestAccVPCNetworkInsightsPath_disappears
=== RUN TestAccVPCNetworkInsightsPath_tags
=== PAUSE TestAccVPCNetworkInsightsPath_tags
=== RUN TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== PAUSE TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== RUN TestAccVPCNetworkInsightsPath_sourceIP
=== PAUSE TestAccVPCNetworkInsightsPath_sourceIP
=== RUN TestAccVPCNetworkInsightsPath_destinationIP
=== PAUSE TestAccVPCNetworkInsightsPath_destinationIP
=== RUN TestAccVPCNetworkInsightsPath_destinationPort
=== PAUSE TestAccVPCNetworkInsightsPath_destinationPort
=== CONT TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== CONT TestAccVPCNetworkInsightsPath_basic
=== CONT TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== CONT TestAccVPCNetworkInsightsPathDataSource_basic
--- PASS: TestAccVPCNetworkInsightsPathDataSource_basic (14.98s)
=== CONT TestAccVPCNetworkInsightsAnalysis_disappears
--- PASS: TestAccVPCNetworkInsightsPath_basic (16.70s)
=== CONT TestAccVPCNetworkInsightsAnalysis_tags
--- PASS: TestAccVPCNetworkInsightsAnalysisDataSource_basic (57.23s)
=== CONT TestAccVPCNetworkInsightsPath_sourceIP
--- PASS: TestAccVPCNetworkInsightsAnalysis_disappears (48.61s)
=== CONT TestAccVPCNetworkInsightsPath_destinationPort
--- PASS: TestAccVPCNetworkInsightsPath_sourceIP (40.43s)
=== CONT TestAccVPCNetworkInsightsPath_destinationIP
--- PASS: TestAccVPCNetworkInsightsAnalysis_tags (81.02s)
=== CONT TestAccVPCNetworkInsightsAnalysis_waitForCompletion
--- PASS: TestAccVPCNetworkInsightsPath_destinationPort (38.25s)
=== CONT TestAccVPCNetworkInsightsPath_tags
--- PASS: TestAccVPCNetworkInsightsAnalysis_waitForCompletion (24.08s)
=== CONT TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
--- PASS: TestAccVPCNetworkInsightsPath_destinationIP (24.95s)
=== CONT TestAccVPCNetworkInsightsAnalysis_basic
--- PASS: TestAccVPCNetworkInsightsPath_tags (32.75s)
=== CONT TestAccVPCNetworkInsightsPath_disappears
--- PASS: TestAccVPCNetworkInsightsPath_sourceAndDestinationARN (15.91s)
--- PASS: TestAccVPCNetworkInsightsPath_disappears (17.49s)
--- PASS: TestAccVPCNetworkInsightsAnalysis_filterInARNs (153.01s)
--- PASS: TestAccVPCNetworkInsightsAnalysis_basic (73.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 200.762s
# Conflicts: # names/data/names_data.csv
This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36129.
Closes #33182.
References
Output from Acceptance Testing