cloudformation: Migrate to AWS SDK v2

[mattburgess]

Description

Relations

Closes #36126

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccCloudFormation' PKG=cloudformation ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/cloudformation/... -v -count 1 -parallel 3  -run=TestAccCloudFormation -timeout 720m
=== RUN   TestAccCloudFormationExportDataSource_basic
=== PAUSE TestAccCloudFormationExportDataSource_basic
=== RUN   TestAccCloudFormationExportDataSource_resourceReference
=== PAUSE TestAccCloudFormationExportDataSource_resourceReference
=== RUN   TestAccCloudFormationStackDataSource_DataSource_basic
=== PAUSE TestAccCloudFormationStackDataSource_DataSource_basic
=== RUN   TestAccCloudFormationStackDataSource_DataSource_yaml
=== PAUSE TestAccCloudFormationStackDataSource_DataSource_yaml
=== RUN   TestAccCloudFormationStackSetInstance_basic
=== PAUSE TestAccCloudFormationStackSetInstance_basic
=== RUN   TestAccCloudFormationStackSetInstance_disappears
=== PAUSE TestAccCloudFormationStackSetInstance_disappears
=== RUN   TestAccCloudFormationStackSetInstance_Disappears_stackSet
=== PAUSE TestAccCloudFormationStackSetInstance_Disappears_stackSet
=== RUN   TestAccCloudFormationStackSetInstance_parameterOverrides
=== PAUSE TestAccCloudFormationStackSetInstance_parameterOverrides
=== RUN   TestAccCloudFormationStackSetInstance_deploymentTargets
=== PAUSE TestAccCloudFormationStackSetInstance_deploymentTargets
=== RUN   TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU
=== PAUSE TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU
=== RUN   TestAccCloudFormationStackSetInstance_operationPreferences
=== PAUSE TestAccCloudFormationStackSetInstance_operationPreferences
=== RUN   TestAccCloudFormationStackSetInstance_delegatedAdministrator
=== PAUSE TestAccCloudFormationStackSetInstance_delegatedAdministrator
=== RUN   TestAccCloudFormationStackSet_basic
=== PAUSE TestAccCloudFormationStackSet_basic
=== RUN   TestAccCloudFormationStackSet_disappears
=== PAUSE TestAccCloudFormationStackSet_disappears
=== RUN   TestAccCloudFormationStackSet_administrationRoleARN
=== PAUSE TestAccCloudFormationStackSet_administrationRoleARN
=== RUN   TestAccCloudFormationStackSet_description
=== PAUSE TestAccCloudFormationStackSet_description
=== RUN   TestAccCloudFormationStackSet_executionRoleName
=== PAUSE TestAccCloudFormationStackSet_executionRoleName
=== RUN   TestAccCloudFormationStackSet_managedExecution
=== PAUSE TestAccCloudFormationStackSet_managedExecution
=== RUN   TestAccCloudFormationStackSet_name
=== PAUSE TestAccCloudFormationStackSet_name
=== RUN   TestAccCloudFormationStackSet_operationPreferences
=== PAUSE TestAccCloudFormationStackSet_operationPreferences
=== RUN   TestAccCloudFormationStackSet_parameters
=== PAUSE TestAccCloudFormationStackSet_parameters
=== RUN   TestAccCloudFormationStackSet_Parameters_default
    stack_set_test.go:478: this resource does not currently ignore unconfigured CloudFormation template parameters with the Default property
--- SKIP: TestAccCloudFormationStackSet_Parameters_default (0.00s)
=== RUN   TestAccCloudFormationStackSet_Parameters_noEcho
    stack_set_test.go:532: this resource does not currently ignore CloudFormation template parameters with the NoEcho property
--- SKIP: TestAccCloudFormationStackSet_Parameters_noEcho (0.00s)
=== RUN   TestAccCloudFormationStackSet_PermissionModel_serviceManaged
    stack_set_test.go:578: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccCloudFormationStackSet_PermissionModel_serviceManaged (0.00s)
=== RUN   TestAccCloudFormationStackSet_tags
=== PAUSE TestAccCloudFormationStackSet_tags
=== RUN   TestAccCloudFormationStackSet_templateBody
=== PAUSE TestAccCloudFormationStackSet_templateBody
=== RUN   TestAccCloudFormationStackSet_templateURL
=== PAUSE TestAccCloudFormationStackSet_templateURL
=== RUN   TestAccCloudFormationStackSet_autoDeploymentEnabled
=== PAUSE TestAccCloudFormationStackSet_autoDeploymentEnabled
=== RUN   TestAccCloudFormationStackSet_autoDeploymentDisabled
=== PAUSE TestAccCloudFormationStackSet_autoDeploymentDisabled
=== RUN   TestAccCloudFormationStackSet_delegatedAdministrator
=== PAUSE TestAccCloudFormationStackSet_delegatedAdministrator
=== RUN   TestAccCloudFormationStack_basic
=== PAUSE TestAccCloudFormationStack_basic
=== RUN   TestAccCloudFormationStack_CreationFailure_doNothing
=== PAUSE TestAccCloudFormationStack_CreationFailure_doNothing
=== RUN   TestAccCloudFormationStack_CreationFailure_delete
=== PAUSE TestAccCloudFormationStack_CreationFailure_delete
=== RUN   TestAccCloudFormationStack_CreationFailure_rollback
=== PAUSE TestAccCloudFormationStack_CreationFailure_rollback
=== RUN   TestAccCloudFormationStack_updateFailure
=== PAUSE TestAccCloudFormationStack_updateFailure
=== RUN   TestAccCloudFormationStack_disappears
=== PAUSE TestAccCloudFormationStack_disappears
=== RUN   TestAccCloudFormationStack_yaml
=== PAUSE TestAccCloudFormationStack_yaml
=== RUN   TestAccCloudFormationStack_defaultParams
=== PAUSE TestAccCloudFormationStack_defaultParams
=== RUN   TestAccCloudFormationStack_allAttributes
=== PAUSE TestAccCloudFormationStack_allAttributes
=== RUN   TestAccCloudFormationStack_withParams
=== PAUSE TestAccCloudFormationStack_withParams
=== RUN   TestAccCloudFormationStack_WithURL_withParams
=== PAUSE TestAccCloudFormationStack_WithURL_withParams
=== RUN   TestAccCloudFormationStack_WithURLWithParams_withYAML
=== PAUSE TestAccCloudFormationStack_WithURLWithParams_withYAML
=== RUN   TestAccCloudFormationStack_WithURLWithParams_noUpdate
=== PAUSE TestAccCloudFormationStack_WithURLWithParams_noUpdate
=== RUN   TestAccCloudFormationStack_withTransform
=== PAUSE TestAccCloudFormationStack_withTransform
=== RUN   TestAccCloudFormationStack_onFailure
=== PAUSE TestAccCloudFormationStack_onFailure
=== RUN   TestAccCloudFormationStack_outputsUpdated
=== PAUSE TestAccCloudFormationStack_outputsUpdated
=== RUN   TestAccCloudFormationStack_templateUpdate
=== PAUSE TestAccCloudFormationStack_templateUpdate
=== RUN   TestAccCloudFormationTypeDataSource_ARN_private
    type_data_source_test.go:22: /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/bin/handler does not exist. To generate locally: cd /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource && make build
--- SKIP: TestAccCloudFormationTypeDataSource_ARN_private (0.00s)
=== RUN   TestAccCloudFormationTypeDataSource_ARN_public
=== PAUSE TestAccCloudFormationTypeDataSource_ARN_public
=== RUN   TestAccCloudFormationTypeDataSource_TypeName_private
    type_data_source_test.go:89: /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/bin/handler does not exist. To generate locally: cd /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource && make build
--- SKIP: TestAccCloudFormationTypeDataSource_TypeName_private (0.00s)
=== RUN   TestAccCloudFormationTypeDataSource_TypeName_public
=== PAUSE TestAccCloudFormationTypeDataSource_TypeName_public
=== RUN   TestAccCloudFormationType_basic
    type_test.go:34: /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/bin/handler does not exist. To generate locally: cd /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource && make build
--- SKIP: TestAccCloudFormationType_basic (0.00s)
=== RUN   TestAccCloudFormationType_disappears
    type_test.go:73: /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/bin/handler does not exist. To generate locally: cd /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource && make build
--- SKIP: TestAccCloudFormationType_disappears (0.00s)
=== RUN   TestAccCloudFormationType_executionRoleARN
    type_test.go:100: /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/bin/handler does not exist. To generate locally: cd /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource && make build
--- SKIP: TestAccCloudFormationType_executionRoleARN (0.00s)
=== RUN   TestAccCloudFormationType_logging
    type_test.go:125: /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/bin/handler does not exist. To generate locally: cd /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource && make build
--- SKIP: TestAccCloudFormationType_logging (0.00s)
=== CONT  TestAccCloudFormationExportDataSource_basic
=== CONT  TestAccCloudFormationStackSet_templateURL
=== CONT  TestAccCloudFormationStack_allAttributes
--- PASS: TestAccCloudFormationExportDataSource_basic (41.20s)
=== CONT  TestAccCloudFormationStack_onFailure
--- PASS: TestAccCloudFormationStackSet_templateURL (78.16s)
=== CONT  TestAccCloudFormationTypeDataSource_TypeName_public
--- PASS: TestAccCloudFormationStack_allAttributes (82.12s)
=== CONT  TestAccCloudFormationTypeDataSource_ARN_public
--- PASS: TestAccCloudFormationTypeDataSource_TypeName_public (14.71s)
=== CONT  TestAccCloudFormationStack_templateUpdate
--- PASS: TestAccCloudFormationTypeDataSource_ARN_public (16.39s)
=== CONT  TestAccCloudFormationStack_outputsUpdated
--- PASS: TestAccCloudFormationStack_onFailure (69.30s)
=== CONT  TestAccCloudFormationStack_WithURLWithParams_withYAML
--- PASS: TestAccCloudFormationStack_templateUpdate (75.93s)
=== CONT  TestAccCloudFormationStack_withTransform
--- PASS: TestAccCloudFormationStack_WithURLWithParams_withYAML (62.32s)
=== CONT  TestAccCloudFormationStack_WithURLWithParams_noUpdate
--- PASS: TestAccCloudFormationStack_outputsUpdated (75.61s)
=== CONT  TestAccCloudFormationStackSet_basic
--- PASS: TestAccCloudFormationStack_withTransform (54.23s)
=== CONT  TestAccCloudFormationStackSet_templateBody
--- PASS: TestAccCloudFormationStackSet_basic (56.05s)
=== CONT  TestAccCloudFormationStackSet_tags
--- PASS: TestAccCloudFormationStack_WithURLWithParams_noUpdate (95.39s)
=== CONT  TestAccCloudFormationStackSet_parameters
--- PASS: TestAccCloudFormationStackSet_templateBody (72.98s)
=== CONT  TestAccCloudFormationStackSet_operationPreferences
--- PASS: TestAccCloudFormationStackSet_tags (95.77s)
=== CONT  TestAccCloudFormationStackSet_name
--- PASS: TestAccCloudFormationStackSet_parameters (121.17s)
=== CONT  TestAccCloudFormationStackSet_managedExecution
--- PASS: TestAccCloudFormationStackSet_name (87.15s)
=== CONT  TestAccCloudFormationStackSet_executionRoleName
--- PASS: TestAccCloudFormationStackSet_managedExecution (45.86s)
=== CONT  TestAccCloudFormationStackSet_description
--- PASS: TestAccCloudFormationStackSet_operationPreferences (166.52s)
=== CONT  TestAccCloudFormationStackSet_administrationRoleARN
--- PASS: TestAccCloudFormationStackSet_executionRoleName (69.22s)
=== CONT  TestAccCloudFormationStackSet_disappears
--- PASS: TestAccCloudFormationStackSet_description (68.90s)
=== CONT  TestAccCloudFormationStack_WithURL_withParams
--- PASS: TestAccCloudFormationStackSet_disappears (51.64s)
=== CONT  TestAccCloudFormationStack_withParams
--- PASS: TestAccCloudFormationStackSet_administrationRoleARN (78.43s)
=== CONT  TestAccCloudFormationStack_CreationFailure_delete
--- PASS: TestAccCloudFormationStack_WithURL_withParams (112.26s)
=== CONT  TestAccCloudFormationStackSetInstance_Disappears_stackSet
--- PASS: TestAccCloudFormationStack_withParams (88.46s)
=== CONT  TestAccCloudFormationStack_defaultParams
--- PASS: TestAccCloudFormationStack_CreationFailure_delete (163.84s)
=== CONT  TestAccCloudFormationStackSetInstance_delegatedAdministrator
    stack_set_instance_test.go:334: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccCloudFormationStackSetInstance_delegatedAdministrator (0.54s)
=== CONT  TestAccCloudFormationStack_yaml
--- PASS: TestAccCloudFormationStackSetInstance_Disappears_stackSet (87.55s)
=== CONT  TestAccCloudFormationStackSetInstance_operationPreferences
    stack_set_instance_test.go:299: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSetInstance_operationPreferences (1.16s)
=== CONT  TestAccCloudFormationStack_disappears
--- PASS: TestAccCloudFormationStack_defaultParams (95.33s)
=== CONT  TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU
    stack_set_instance_test.go:254: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU (0.72s)
=== CONT  TestAccCloudFormationStack_updateFailure
--- PASS: TestAccCloudFormationStack_yaml (59.33s)
=== CONT  TestAccCloudFormationStackSetInstance_deploymentTargets
    stack_set_instance_test.go:209: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSetInstance_deploymentTargets (0.71s)
=== CONT  TestAccCloudFormationStack_CreationFailure_rollback
--- PASS: TestAccCloudFormationStack_disappears (68.65s)
=== CONT  TestAccCloudFormationStackSetInstance_parameterOverrides
--- PASS: TestAccCloudFormationStack_updateFailure (61.38s)
=== CONT  TestAccCloudFormationStackDataSource_DataSource_basic
--- PASS: TestAccCloudFormationStackDataSource_DataSource_basic (49.90s)
=== CONT  TestAccCloudFormationStackSetInstance_disappears
--- PASS: TestAccCloudFormationStackSetInstance_disappears (85.25s)
=== CONT  TestAccCloudFormationStackDataSource_DataSource_yaml
--- PASS: TestAccCloudFormationStackSetInstance_parameterOverrides (162.99s)
=== CONT  TestAccCloudFormationStackSetInstance_basic
--- PASS: TestAccCloudFormationStack_CreationFailure_rollback (163.97s)
=== CONT  TestAccCloudFormationExportDataSource_resourceReference
--- PASS: TestAccCloudFormationStackDataSource_DataSource_yaml (49.20s)
=== CONT  TestAccCloudFormationStackSet_delegatedAdministrator
    stack_set_test.go:848: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccCloudFormationStackSet_delegatedAdministrator (0.48s)
=== CONT  TestAccCloudFormationStackSet_autoDeploymentDisabled
    stack_set_test.go:803: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSet_autoDeploymentDisabled (0.87s)
=== CONT  TestAccCloudFormationStack_CreationFailure_doNothing
--- PASS: TestAccCloudFormationExportDataSource_resourceReference (47.86s)
=== CONT  TestAccCloudFormationStackSet_autoDeploymentEnabled
    stack_set_test.go:764: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSet_autoDeploymentEnabled (0.53s)
=== CONT  TestAccCloudFormationStack_basic
--- PASS: TestAccCloudFormationStackSetInstance_basic (84.36s)
--- PASS: TestAccCloudFormationStack_basic (57.56s)
--- PASS: TestAccCloudFormationStack_CreationFailure_doNothing (163.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	1192.827s

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccCloudFormationStackSetInstance_operationPreferences\|TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU\|TestAccCloudFormationStackSetInstance_deploymentTargets\|TestAccCloudFormationStackSet_autoDeploymentDisabled\|TestAccCloudFormationStackSet_autoDeploymentEnabled' PKG=cloudformation ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/cloudformation/... -v -count 1 -parallel 3  -run=TestAccCloudFormationStackSetInstance_operationPreferences\|TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU\|TestAccCloudFormationStackSetInstance_deploymentTargets\|TestAccCloudFormationStackSet_autoDeploymentDisabled\|TestAccCloudFormationStackSet_autoDeploymentEnabled -timeout 720m
=== RUN   TestAccCloudFormationStackSetInstance_deploymentTargets
=== PAUSE TestAccCloudFormationStackSetInstance_deploymentTargets
=== RUN   TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU
=== PAUSE TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU
=== RUN   TestAccCloudFormationStackSetInstance_operationPreferences
=== PAUSE TestAccCloudFormationStackSetInstance_operationPreferences
=== RUN   TestAccCloudFormationStackSet_autoDeploymentEnabled
=== PAUSE TestAccCloudFormationStackSet_autoDeploymentEnabled
=== RUN   TestAccCloudFormationStackSet_autoDeploymentDisabled
=== PAUSE TestAccCloudFormationStackSet_autoDeploymentDisabled
=== CONT  TestAccCloudFormationStackSetInstance_deploymentTargets
=== CONT  TestAccCloudFormationStackSet_autoDeploymentEnabled
=== CONT  TestAccCloudFormationStackSet_autoDeploymentDisabled
--- PASS: TestAccCloudFormationStackSet_autoDeploymentEnabled (41.58s)
=== CONT  TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU
--- PASS: TestAccCloudFormationStackSet_autoDeploymentDisabled (41.95s)
=== CONT  TestAccCloudFormationStackSetInstance_operationPreferences
--- PASS: TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU (69.65s)
--- PASS: TestAccCloudFormationStackSetInstance_operationPreferences (135.11s)
--- PASS: TestAccCloudFormationStackSetInstance_deploymentTargets (177.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	187.703s

[ewbankkit]

@mattburgess Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.