Tech debt: Migrateevents resources to AWS SDK for Go v2

[ewbankkit]

Description

Ibid.

Relations

Closes #36160.
Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEvents' PKG=events ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/events/... -v -count 1 -parallel 3  -run=TestAccEvents -timeout 360m
=== RUN   TestAccEventsAPIDestination_basic
=== PAUSE TestAccEventsAPIDestination_basic
=== RUN   TestAccEventsAPIDestination_optional
=== PAUSE TestAccEventsAPIDestination_optional
=== RUN   TestAccEventsAPIDestination_disappears
=== PAUSE TestAccEventsAPIDestination_disappears
=== RUN   TestAccEventsArchive_basic
=== PAUSE TestAccEventsArchive_basic
=== RUN   TestAccEventsArchive_update
=== PAUSE TestAccEventsArchive_update
=== RUN   TestAccEventsArchive_disappears
=== PAUSE TestAccEventsArchive_disappears
=== RUN   TestAccEventsArchive_retentionSetOnCreation
=== PAUSE TestAccEventsArchive_retentionSetOnCreation
=== RUN   TestAccEventsBusDataSource_basic
=== PAUSE TestAccEventsBusDataSource_basic
=== RUN   TestAccEventsBusPolicy_basic
=== PAUSE TestAccEventsBusPolicy_basic
=== RUN   TestAccEventsBusPolicy_ignoreEquivalent
=== PAUSE TestAccEventsBusPolicy_ignoreEquivalent
=== RUN   TestAccEventsBusPolicy_disappears
=== PAUSE TestAccEventsBusPolicy_disappears
=== RUN   TestAccEventsBusPolicy_disappears_EventBus
=== PAUSE TestAccEventsBusPolicy_disappears_EventBus
=== RUN   TestAccEventsBus_basic
=== PAUSE TestAccEventsBus_basic
=== RUN   TestAccEventsBus_tags
=== PAUSE TestAccEventsBus_tags
=== RUN   TestAccEventsBus_default
=== PAUSE TestAccEventsBus_default
=== RUN   TestAccEventsBus_disappears
=== PAUSE TestAccEventsBus_disappears
=== RUN   TestAccEventsBus_partnerEventSource
    bus_test.go:171: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
=== RUN   TestAccEventsConnectionDataSource_Connection_basic
=== PAUSE TestAccEventsConnectionDataSource_Connection_basic
=== RUN   TestAccEventsConnection_apiKey
=== PAUSE TestAccEventsConnection_apiKey
=== RUN   TestAccEventsConnection_basic
=== PAUSE TestAccEventsConnection_basic
=== RUN   TestAccEventsConnection_oAuth
=== PAUSE TestAccEventsConnection_oAuth
=== RUN   TestAccEventsConnection_invocationHTTPParameters
=== PAUSE TestAccEventsConnection_invocationHTTPParameters
=== RUN   TestAccEventsConnection_disappears
=== PAUSE TestAccEventsConnection_disappears
=== RUN   TestAccEventsEndpoint_basic
=== PAUSE TestAccEventsEndpoint_basic
=== RUN   TestAccEventsEndpoint_disappears
=== PAUSE TestAccEventsEndpoint_disappears
=== RUN   TestAccEventsEndpoint_roleARN
=== PAUSE TestAccEventsEndpoint_roleARN
=== RUN   TestAccEventsEndpoint_description
=== PAUSE TestAccEventsEndpoint_description
=== RUN   TestAccEventsEndpoint_updateRoutingConfig
=== PAUSE TestAccEventsEndpoint_updateRoutingConfig
=== RUN   TestAccEventsPermission_basic
=== PAUSE TestAccEventsPermission_basic
=== RUN   TestAccEventsPermission_eventBusName
=== PAUSE TestAccEventsPermission_eventBusName
=== RUN   TestAccEventsPermission_action
=== PAUSE TestAccEventsPermission_action
=== RUN   TestAccEventsPermission_condition
=== PAUSE TestAccEventsPermission_condition
=== RUN   TestAccEventsPermission_multiple
=== PAUSE TestAccEventsPermission_multiple
=== RUN   TestAccEventsPermission_disappears
=== PAUSE TestAccEventsPermission_disappears
=== RUN   TestAccEventsRule_basic
=== PAUSE TestAccEventsRule_basic
=== RUN   TestAccEventsRule_eventBusName
=== PAUSE TestAccEventsRule_eventBusName
=== RUN   TestAccEventsRule_role
=== PAUSE TestAccEventsRule_role
=== RUN   TestAccEventsRule_description
=== PAUSE TestAccEventsRule_description
=== RUN   TestAccEventsRule_pattern
=== PAUSE TestAccEventsRule_pattern
=== RUN   TestAccEventsRule_patternJSONEncoder
=== PAUSE TestAccEventsRule_patternJSONEncoder
=== RUN   TestAccEventsRule_scheduleAndPattern
=== PAUSE TestAccEventsRule_scheduleAndPattern
=== RUN   TestAccEventsRule_namePrefix
=== PAUSE TestAccEventsRule_namePrefix
=== RUN   TestAccEventsRule_Name_generated
=== PAUSE TestAccEventsRule_Name_generated
=== RUN   TestAccEventsRule_tags
=== PAUSE TestAccEventsRule_tags
=== RUN   TestAccEventsRule_isEnabled
=== PAUSE TestAccEventsRule_isEnabled
=== RUN   TestAccEventsRule_state
=== PAUSE TestAccEventsRule_state
=== RUN   TestAccEventsRule_partnerEventBus
    rule_test.go:687: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
=== RUN   TestAccEventsRule_eventBusARN
=== PAUSE TestAccEventsRule_eventBusARN
=== RUN   TestAccEventsRule_migrateV0
=== PAUSE TestAccEventsRule_migrateV0
=== RUN   TestAccEventsRule_migrateV0_Equivalent
=== PAUSE TestAccEventsRule_migrateV0_Equivalent
=== RUN   TestAccEventsSourceDataSource_basic
    source_data_source_test.go:22: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsSourceDataSource_basic (0.00s)
=== RUN   TestAccEventsTarget_basic
=== PAUSE TestAccEventsTarget_basic
=== RUN   TestAccEventsTarget_disappears
=== PAUSE TestAccEventsTarget_disappears
=== RUN   TestAccEventsTarget_eventBusName
=== PAUSE TestAccEventsTarget_eventBusName
=== RUN   TestAccEventsTarget_eventBusARN
=== PAUSE TestAccEventsTarget_eventBusARN
=== RUN   TestAccEventsTarget_generatedTargetID
=== PAUSE TestAccEventsTarget_generatedTargetID
=== RUN   TestAccEventsTarget_RetryPolicy_deadLetter
=== PAUSE TestAccEventsTarget_RetryPolicy_deadLetter
=== RUN   TestAccEventsTarget_full
=== PAUSE TestAccEventsTarget_full
=== RUN   TestAccEventsTarget_ssmDocument
=== PAUSE TestAccEventsTarget_ssmDocument
=== RUN   TestAccEventsTarget_http
=== PAUSE TestAccEventsTarget_http
=== RUN   TestAccEventsTarget_http_params
=== PAUSE TestAccEventsTarget_http_params
=== RUN   TestAccEventsTarget_ecs
=== PAUSE TestAccEventsTarget_ecs
=== RUN   TestAccEventsTarget_redshift
=== PAUSE TestAccEventsTarget_redshift
=== RUN   TestAccEventsTarget_ecsWithoutLaunchType
=== PAUSE TestAccEventsTarget_ecsWithoutLaunchType
=== RUN   TestAccEventsTarget_ecsWithBlankLaunchType
=== PAUSE TestAccEventsTarget_ecsWithBlankLaunchType
=== RUN   TestAccEventsTarget_ecsWithBlankTaskCount
=== PAUSE TestAccEventsTarget_ecsWithBlankTaskCount
=== RUN   TestAccEventsTarget_ecsFull
=== PAUSE TestAccEventsTarget_ecsFull
=== RUN   TestAccEventsTarget_ecsCapacityProvider
=== PAUSE TestAccEventsTarget_ecsCapacityProvider
=== RUN   TestAccEventsTarget_ecsPlacementStrategy
=== PAUSE TestAccEventsTarget_ecsPlacementStrategy
=== RUN   TestAccEventsTarget_batch
=== PAUSE TestAccEventsTarget_batch
=== RUN   TestAccEventsTarget_kinesis
=== PAUSE TestAccEventsTarget_kinesis
=== RUN   TestAccEventsTarget_sqs
=== PAUSE TestAccEventsTarget_sqs
=== RUN   TestAccEventsTarget_sageMakerPipeline
=== PAUSE TestAccEventsTarget_sageMakerPipeline
=== RUN   TestAccEventsTarget_Input_transformer
=== PAUSE TestAccEventsTarget_Input_transformer
=== RUN   TestAccEventsTarget_inputTransformerJSONString
=== PAUSE TestAccEventsTarget_inputTransformerJSONString
=== RUN   TestAccEventsTarget_partnerEventBus
    target_test.go:1109: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsTarget_partnerEventBus (0.00s)
=== RUN   TestAccEventsTarget_ecsNoPropagateTags
=== PAUSE TestAccEventsTarget_ecsNoPropagateTags
=== CONT  TestAccEventsAPIDestination_basic
=== CONT  TestAccEventsRule_scheduleAndPattern
=== CONT  TestAccEventsConnection_invocationHTTPParameters
--- PASS: TestAccEventsRule_scheduleAndPattern (27.04s)
=== CONT  TestAccEventsTarget_http
--- PASS: TestAccEventsTarget_http (38.72s)
=== CONT  TestAccEventsTarget_ecsNoPropagateTags
--- PASS: TestAccEventsConnection_invocationHTTPParameters (75.51s)
=== CONT  TestAccEventsTarget_inputTransformerJSONString
--- PASS: TestAccEventsAPIDestination_basic (87.73s)
=== CONT  TestAccEventsTarget_Input_transformer
--- PASS: TestAccEventsTarget_Input_transformer (43.57s)
=== CONT  TestAccEventsTarget_sageMakerPipeline
--- PASS: TestAccEventsTarget_inputTransformerJSONString (45.21s)
=== CONT  TestAccEventsTarget_sqs
--- PASS: TestAccEventsTarget_sageMakerPipeline (33.21s)
=== CONT  TestAccEventsTarget_kinesis
--- PASS: TestAccEventsTarget_sqs (59.67s)
=== CONT  TestAccEventsTarget_batch
--- PASS: TestAccEventsTarget_kinesis (68.38s)
=== CONT  TestAccEventsTarget_ecsPlacementStrategy
--- PASS: TestAccEventsTarget_batch (127.39s)
=== CONT  TestAccEventsTarget_ecsCapacityProvider
--- PASS: TestAccEventsTarget_ecsNoPropagateTags (288.22s)
=== CONT  TestAccEventsTarget_ecsFull
--- PASS: TestAccEventsTarget_ecsCapacityProvider (64.60s)
=== CONT  TestAccEventsTarget_ecsWithBlankTaskCount
--- PASS: TestAccEventsTarget_ecsFull (35.27s)
=== CONT  TestAccEventsTarget_ecsWithBlankLaunchType
--- PASS: TestAccEventsTarget_ecsWithBlankTaskCount (34.56s)
=== CONT  TestAccEventsTarget_ecsWithoutLaunchType
--- PASS: TestAccEventsTarget_ecsWithBlankLaunchType (69.72s)
=== CONT  TestAccEventsTarget_redshift
--- PASS: TestAccEventsTarget_ecsWithoutLaunchType (70.30s)
=== CONT  TestAccEventsTarget_ecs
--- PASS: TestAccEventsTarget_ecs (37.50s)
=== CONT  TestAccEventsTarget_http_params
--- PASS: TestAccEventsTarget_http_params (34.92s)
=== CONT  TestAccEventsBusPolicy_disappears
--- PASS: TestAccEventsBusPolicy_disappears (17.32s)
=== CONT  TestAccEventsConnection_oAuth
--- PASS: TestAccEventsConnection_oAuth (47.66s)
=== CONT  TestAccEventsRule_patternJSONEncoder
--- PASS: TestAccEventsRule_patternJSONEncoder (15.98s)
=== CONT  TestAccEventsRule_pattern
--- PASS: TestAccEventsRule_pattern (32.39s)
=== CONT  TestAccEventsRule_description
--- PASS: TestAccEventsRule_description (31.76s)
=== CONT  TestAccEventsBus_default
--- PASS: TestAccEventsBus_default (2.33s)
=== CONT  TestAccEventsRule_role
--- PASS: TestAccEventsRule_role (30.55s)
=== CONT  TestAccEventsBus_tags
--- PASS: TestAccEventsBus_tags (43.78s)
=== CONT  TestAccEventsBus_basic
--- PASS: TestAccEventsBus_basic (47.15s)
=== CONT  TestAccEventsBusPolicy_disappears_EventBus
--- PASS: TestAccEventsBusPolicy_disappears_EventBus (18.27s)
=== CONT  TestAccEventsRule_eventBusName
--- PASS: TestAccEventsTarget_redshift (425.62s)
=== CONT  TestAccEventsRule_basic
--- PASS: TestAccEventsRule_eventBusName (48.20s)
=== CONT  TestAccEventsPermission_disappears
--- PASS: TestAccEventsRule_basic (49.47s)
=== CONT  TestAccEventsBus_disappears
--- PASS: TestAccEventsBus_disappears (17.41s)
=== CONT  TestAccEventsConnection_basic
--- PASS: TestAccEventsConnection_basic (46.42s)
=== CONT  TestAccEventsConnection_apiKey
--- PASS: TestAccEventsPermission_disappears (138.14s)
=== CONT  TestAccEventsTarget_basic
--- PASS: TestAccEventsConnection_apiKey (49.54s)
=== CONT  TestAccEventsTarget_ssmDocument
--- PASS: TestAccEventsTarget_basic (34.79s)
=== CONT  TestAccEventsTarget_full
--- PASS: TestAccEventsTarget_ssmDocument (23.46s)
=== CONT  TestAccEventsPermission_multiple
--- PASS: TestAccEventsPermission_multiple (31.04s)
=== CONT  TestAccEventsPermission_condition
--- PASS: TestAccEventsTarget_full (54.46s)
=== CONT  TestAccEventsPermission_action
--- PASS: TestAccEventsPermission_condition (31.73s)
=== CONT  TestAccEventsPermission_eventBusName
--- PASS: TestAccEventsPermission_action (24.46s)
=== CONT  TestAccEventsPermission_basic
--- PASS: TestAccEventsPermission_eventBusName (20.73s)
=== CONT  TestAccEventsEndpoint_updateRoutingConfig
--- PASS: TestAccEventsPermission_basic (46.69s)
=== CONT  TestAccEventsTarget_RetryPolicy_deadLetter
--- PASS: TestAccEventsEndpoint_updateRoutingConfig (43.27s)
=== CONT  TestAccEventsTarget_eventBusName
--- PASS: TestAccEventsTarget_eventBusName (20.74s)
=== CONT  TestAccEventsTarget_disappears
--- PASS: TestAccEventsTarget_disappears (18.39s)
=== CONT  TestAccEventsEndpoint_description
--- PASS: TestAccEventsTarget_RetryPolicy_deadLetter (57.80s)
=== CONT  TestAccEventsTarget_eventBusARN
--- PASS: TestAccEventsTarget_eventBusARN (22.18s)
=== CONT  TestAccEventsEndpoint_basic
--- PASS: TestAccEventsEndpoint_description (49.31s)
=== CONT  TestAccEventsTarget_generatedTargetID
--- PASS: TestAccEventsEndpoint_basic (31.11s)
=== CONT  TestAccEventsEndpoint_disappears
--- PASS: TestAccEventsTarget_generatedTargetID (21.73s)
=== CONT  TestAccEventsConnection_disappears
--- PASS: TestAccEventsEndpoint_disappears (30.10s)
=== CONT  TestAccEventsArchive_disappears
--- PASS: TestAccEventsConnection_disappears (19.17s)
=== CONT  TestAccEventsBusPolicy_basic
--- PASS: TestAccEventsArchive_disappears (18.57s)
=== CONT  TestAccEventsBusDataSource_basic
--- PASS: TestAccEventsBusDataSource_basic (16.82s)
=== CONT  TestAccEventsEndpoint_roleARN
--- PASS: TestAccEventsBusPolicy_basic (33.87s)
=== CONT  TestAccEventsArchive_retentionSetOnCreation
--- PASS: TestAccEventsArchive_retentionSetOnCreation (21.11s)
=== CONT  TestAccEventsRule_state
--- PASS: TestAccEventsEndpoint_roleARN (44.08s)
=== CONT  TestAccEventsRule_eventBusARN
--- PASS: TestAccEventsRule_state (40.93s)
=== CONT  TestAccEventsRule_migrateV0
=== RUN   TestAccEventsRule_migrateV0/enabled
=== PAUSE TestAccEventsRule_migrateV0/enabled
=== RUN   TestAccEventsRule_migrateV0/disabled
=== PAUSE TestAccEventsRule_migrateV0/disabled
=== RUN   TestAccEventsRule_migrateV0/basic
=== PAUSE TestAccEventsRule_migrateV0/basic
=== CONT  TestAccEventsRule_migrateV0_Equivalent
=== RUN   TestAccEventsRule_migrateV0_Equivalent/enabled
=== PAUSE TestAccEventsRule_migrateV0_Equivalent/enabled
=== RUN   TestAccEventsRule_migrateV0_Equivalent/disabled
=== PAUSE TestAccEventsRule_migrateV0_Equivalent/disabled
=== CONT  TestAccEventsRule_tags
--- PASS: TestAccEventsRule_eventBusARN (22.75s)
=== CONT  TestAccEventsRule_isEnabled
=== NAME  TestAccEventsTarget_ecsPlacementStrategy
    target_test.go:865: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: waiting for ECS Capacity Provider (arn:aws:ecs:us-west-2:187416307283:capacity-provider/tf-acc-test-9219820016161702406) to delete: timeout while waiting for resource to be gone (last state: 'ACTIVE', timeout: 20m0s)
        
--- FAIL: TestAccEventsTarget_ecsPlacementStrategy (1263.78s)
=== CONT  TestAccEventsArchive_basic
--- PASS: TestAccEventsRule_tags (53.10s)
=== CONT  TestAccEventsAPIDestination_disappears
--- PASS: TestAccEventsArchive_basic (25.86s)
=== CONT  TestAccEventsRule_Name_generated
--- PASS: TestAccEventsRule_isEnabled (58.66s)
=== CONT  TestAccEventsConnectionDataSource_Connection_basic
--- PASS: TestAccEventsAPIDestination_disappears (24.73s)
=== CONT  TestAccEventsBusPolicy_ignoreEquivalent
--- PASS: TestAccEventsConnectionDataSource_Connection_basic (21.45s)
=== CONT  TestAccEventsAPIDestination_optional
--- PASS: TestAccEventsRule_Name_generated (24.39s)
=== CONT  TestAccEventsRule_namePrefix
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (28.54s)
=== CONT  TestAccEventsArchive_update
--- PASS: TestAccEventsRule_namePrefix (24.89s)
=== CONT  TestAccEventsRule_migrateV0/enabled
=== CONT  TestAccEventsRule_migrateV0/basic
=== CONT  TestAccEventsRule_migrateV0/disabled
--- PASS: TestAccEventsRule_migrateV0 (0.00s)
    --- PASS: TestAccEventsRule_migrateV0/basic (90.17s)
    --- PASS: TestAccEventsRule_migrateV0/disabled (94.71s)
    --- PASS: TestAccEventsRule_migrateV0/enabled (85.37s)
=== CONT  TestAccEventsRule_migrateV0_Equivalent/enabled
=== CONT  TestAccEventsRule_migrateV0_Equivalent/disabled
--- PASS: TestAccEventsRule_migrateV0_Equivalent (0.00s)
    --- PASS: TestAccEventsRule_migrateV0_Equivalent/disabled (81.39s)
    --- PASS: TestAccEventsRule_migrateV0_Equivalent/enabled (91.35s)
--- PASS: TestAccEventsAPIDestination_optional (56.84s)
--- PASS: TestAccEventsArchive_update (35.85s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/events	1577.267s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change and is occurring in CI.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.