Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t - aws glue job #36770

Merged
merged 6 commits into from
Apr 16, 2024
Merged

t - aws glue job #36770

merged 6 commits into from
Apr 16, 2024

Commits on Apr 6, 2024

  1. Configuration menu
    Copy the full SHA
    3380d20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b8e32e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a9d38a8 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    495798d View commit details
    Browse the repository at this point in the history
  2. r/aws_glue_job: number_of_workers and worker_type are optional/computed

    Previously these arguments were optional only, but it appears the read operation can now return non-nil values for these attributes when `max_capacity` is set. Marking these as optional/computed prevents persistent differences (and fixes several failing acceptance tests).
    
    ```console
    % make testacc PKG=glue TESTS=TestAccGlueJob_
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.21.8 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_'  -timeout 360m
    
    --- PASS: TestAccGlueJob_rayJob (31.89s)
    --- PASS: TestAccGlueJob_disappears (33.39s)
    --- PASS: TestAccGlueJob_basicStreaming (36.27s)
    --- PASS: TestAccGlueJob_basic (38.12s)
    --- PASS: TestAccGlueJob_nonOverridableArguments (54.61s)
    --- PASS: TestAccGlueJob_description (54.71s)
    --- PASS: TestAccGlueJob_defaultArguments (54.78s)
    --- PASS: TestAccGlueJob_maxCapacity (54.89s)
    --- PASS: TestAccGlueJob_timeout (54.91s)
    --- PASS: TestAccGlueJob_command (55.50s)
    --- PASS: TestAccGlueJob_security (55.58s)
    --- PASS: TestAccGlueJob_executionClass (55.72s)
    --- PASS: TestAccGlueJob_streamingTimeout (55.78s)
    --- PASS: TestAccGlueJob_maxRetries (56.43s)
    --- PASS: TestAccGlueJob_executionProperty (56.49s)
    --- PASS: TestAccGlueJob_notificationProperty (57.15s)
    --- PASS: TestAccGlueJob_tags (63.00s)
    --- PASS: TestAccGlueJob_glueVersion (63.46s)
    --- PASS: TestAccGlueJob_pythonShell (73.20s)
    --- PASS: TestAccGlueJob_workerType (79.32s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       84.990s
    ```
    jar-b committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    811aef3 View commit details
    Browse the repository at this point in the history
  3. chore: changelog

    jar-b committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5b4d557 View commit details
    Browse the repository at this point in the history