-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Function]: trim_iam_role_path
#36723
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% go test ./internal/function/... -run=TestTrimIAMRolePathFunction_
ok github.com/hashicorp/terraform-provider-aws/internal/function 11.471s
function is implied by the parent directory.
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
This function will allow practitioners to trim the path prefix from a provided IAM role ARN. Removal of the path prefix is required in situations such as passing the role into the ConfigMap for an EKS cluster. ```console % go test ./internal/function/... -run=TestTrimIAMRolePathFunction_ ok github.com/hashicorp/terraform-provider-aws/internal/function 10.147s ```
bb78ec7
to
0c04284
Compare
This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This function will allow practitioners to trim the path prefix from a provided IAM role ARN. Removal of the path prefix is required in situations such as passing the role into the ConfigMap for an EKS cluster.
Relations
Closes #36679
References
Output from Acceptance Testing