-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key_value_store_associations
to aws_cloudfront_function
#36585
Add key_value_store_associations
to aws_cloudfront_function
#36585
Conversation
…ns` field description
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCloudFrontFunction_\|TestAccCloudFrontFunctionDataSource_' PKG=cloudfront ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/cloudfront/... -v -count 1 -parallel 3 -run=TestAccCloudFrontFunction_\|TestAccCloudFrontFunctionDataSource_ -timeout 360m
=== RUN TestAccCloudFrontFunctionDataSource_basic
=== PAUSE TestAccCloudFrontFunctionDataSource_basic
=== RUN TestAccCloudFrontFunction_basic
=== PAUSE TestAccCloudFrontFunction_basic
=== RUN TestAccCloudFrontFunction_disappears
=== PAUSE TestAccCloudFrontFunction_disappears
=== RUN TestAccCloudFrontFunction_publish
=== PAUSE TestAccCloudFrontFunction_publish
=== RUN TestAccCloudFrontFunction_associated
=== PAUSE TestAccCloudFrontFunction_associated
=== RUN TestAccCloudFrontFunction_Update_code
=== PAUSE TestAccCloudFrontFunction_Update_code
=== RUN TestAccCloudFrontFunction_UpdateCodeAndPublish
=== PAUSE TestAccCloudFrontFunction_UpdateCodeAndPublish
=== RUN TestAccCloudFrontFunction_Update_comment
=== PAUSE TestAccCloudFrontFunction_Update_comment
=== RUN TestAccCloudFrontFunction_KeyValueStoreAssociations
=== PAUSE TestAccCloudFrontFunction_KeyValueStoreAssociations
=== CONT TestAccCloudFrontFunctionDataSource_basic
=== CONT TestAccCloudFrontFunction_Update_code
=== CONT TestAccCloudFrontFunction_Update_comment
--- PASS: TestAccCloudFrontFunctionDataSource_basic (41.84s)
=== CONT TestAccCloudFrontFunction_UpdateCodeAndPublish
--- PASS: TestAccCloudFrontFunction_Update_code (48.20s)
=== CONT TestAccCloudFrontFunction_publish
--- PASS: TestAccCloudFrontFunction_Update_comment (49.15s)
=== CONT TestAccCloudFrontFunction_associated
--- PASS: TestAccCloudFrontFunction_UpdateCodeAndPublish (44.07s)
=== CONT TestAccCloudFrontFunction_disappears
--- PASS: TestAccCloudFrontFunction_publish (40.88s)
=== CONT TestAccCloudFrontFunction_KeyValueStoreAssociations
--- PASS: TestAccCloudFrontFunction_disappears (20.97s)
=== CONT TestAccCloudFrontFunction_basic
--- PASS: TestAccCloudFrontFunction_basic (27.52s)
--- PASS: TestAccCloudFrontFunction_KeyValueStoreAssociations (97.23s)
--- PASS: TestAccCloudFrontFunction_associated (542.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 604.036s
@brittandeyoung @surajsubramanian Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR uses the commits on another PR #36228 , and adds the ability to associate
aws_cloudfront_key_value_store
to anaws_cloudfront_function
.Relations
Closes #36048
Closes #35889
Closes #36228
References
Output from Acceptance Testing