Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] : Validation function for RDS performance_insights_retention_period attribute #35870

Merged
merged 5 commits into from
Feb 20, 2024
Merged

[Enhancement] : Validation function for RDS performance_insights_retention_period attribute #35870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71e655f
b-validate performance retention period
Jebaseelanravi Feb 17, 2024
0b059d5
add changelog
Jebaseelanravi Feb 17, 2024
29c5f73
fix linting
Jebaseelanravi Feb 18, 2024
89799b4
Tweak CHANGELOG entry.
ewbankkit Feb 20, 2024
0ca2611
Fix 'TestAccRDSInstance_PerformanceInsights_retentionPeriod'.
ewbankkit Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/35870.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_db_instance: Add plan-time validation of `performance_insights_retention_period`
```
4 changes: 4 additions & 0 deletions internal/service/rds/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,10 @@ func ResourceInstance() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
Computed: true,
ValidateFunc: validation.Any(
validation.IntInSlice([]int{7, 731}),
validation.IntDivisibleBy(31),
),
},
"port": {
Type: schema.TypeInt,
Expand Down
Loading