Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/medialive_channel: add client_cache to HLS group settings #35738

Merged
merged 6 commits into from
Feb 9, 2024
Merged

r/medialive_channel: add client_cache to HLS group settings #35738

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7fd9f4
added client_cache to expandHLSGroupSettings
peletv2 Oct 6, 2023
98a0ce9
changelog
peletv2 Oct 6, 2023
473824f
test
peletv2 Oct 9, 2023
07f938d
Merge branch 'b-aws_medialive_channel_hls_group_settings_client_cache…
johnsonaj Feb 9, 2024
6c816ba
update CHANGELOG
johnsonaj Feb 9, 2024
d3c3e47
aws_medialive_channel: check NotFound during delete
johnsonaj Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/35738.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_medialive_channel: Added `client_cache` to `hls_group_settings`.
```
3 changes: 3 additions & 0 deletions internal/service/medialive/channel_encoder_settings_schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3697,6 +3697,9 @@ func expandHLSGroupSettings(tfList []interface{}) *types.HlsGroupSettings {
if v, ok := m["caption_language_setting"].(string); ok && v != "" {
out.CaptionLanguageSetting = types.HlsCaptionLanguageSetting(v)
}
if v, ok := m["client_cache"].(string); ok && v != "" {
out.ClientCache = types.HlsClientCache(v)
}
if v, ok := m["codec_specification"].(string); ok && v != "" {
out.CodecSpecification = types.HlsCodecSpecification(v)
}
Expand Down
2 changes: 2 additions & 0 deletions internal/service/medialive/channel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,7 @@ func TestAccMediaLiveChannel_hls(t *testing.T) {
"name": "test-video-name",
}),
resource.TestCheckResourceAttr(resourceName, "encoder_settings.0.output_groups.0.outputs.0.output_settings.0.hls_output_settings.0.h265_packaging_type", "HVC1"),
resource.TestCheckResourceAttr(resourceName, "encoder_settings.0.output_groups.0.output_group_settings.0.hls_group_settings.0.client_cache", "ENABLED"),
),
},
},
Expand Down Expand Up @@ -1774,6 +1775,7 @@ resource "aws_medialive_channel" "test" {
destination {
destination_ref_id = %[1]q
}
client_cache = "ENABLED"
}
}

Expand Down
Loading