Fix unsupported properties for lambda compute types in `codebuild`. #35043

shblue21 · 2023-12-22T12:20:59Z

Description

In November, AWS CodeBuild released the ability to build using the Lambda runtime.
Lambda runtime does not have a queued_timeout build_timeout property.
However, due to the build_timeout, queue_timeout default, it tries to assign a default value every time you replace Compute_Type with Lambda, resulting in an error.

	"queued_timeout": {
		Type:         schema.TypeInt,
		Optional:     true,
		Default:      480,
...
	"build_timeout": {
		Type:         schema.TypeInt,
		Optional:     true,
		Default:      60,
}

Relations

Closes #34376

References

Why doesn't the Lambda runtime have a `build_timeout`, `queued_timeout`?

Since CodeBuild runs its own Container, it has a queued_timeout property that can handle exceptions until the Container runs.
However, lambdas have a very short warm-up time, so they don't have that property.
URL
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/codebuild/types#EnvironmentType

Output from Acceptance Testing

% make testacc TESTS=TestAccCodeBuildProject_queuedTimeout PKG=codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildProject_queuedTimeout'  -timeout 360m
=== RUN   TestAccCodeBuildProject_queuedTimeout
=== PAUSE TestAccCodeBuildProject_queuedTimeout
=== CONT  TestAccCodeBuildProject_queuedTimeout
--- PASS: TestAccCodeBuildProject_queuedTimeout (44.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  46.363s
...
% make testacc TESTS=TestAccCodeBuildProject_linuxLambdaContainer PKG=codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildProject_linuxLambdaContainer'  -timeout 360m
=== RUN   TestAccCodeBuildProject_linuxLambdaContainer
=== PAUSE TestAccCodeBuildProject_linuxLambdaContainer
=== CONT  TestAccCodeBuildProject_linuxLambdaContainer
--- PASS: TestAccCodeBuildProject_linuxLambdaContainer (25.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  27.824s
...

github-actions · 2023-12-22T12:21:14Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…s Lambda

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeBuildProject_' PKG=codebuild ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 2  -run=TestAccCodeBuildProject_ -timeout 360m
=== RUN   TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN   TestAccCodeBuildProject_publicVisibility
=== PAUSE TestAccCodeBuildProject_publicVisibility
=== RUN   TestAccCodeBuildProject_badgeEnabled
=== PAUSE TestAccCodeBuildProject_badgeEnabled
=== RUN   TestAccCodeBuildProject_buildTimeout
=== PAUSE TestAccCodeBuildProject_buildTimeout
=== RUN   TestAccCodeBuildProject_queuedTimeout
=== PAUSE TestAccCodeBuildProject_queuedTimeout
=== RUN   TestAccCodeBuildProject_cache
=== PAUSE TestAccCodeBuildProject_cache
=== RUN   TestAccCodeBuildProject_description
=== PAUSE TestAccCodeBuildProject_description
=== RUN   TestAccCodeBuildProject_fileSystemLocations
=== PAUSE TestAccCodeBuildProject_fileSystemLocations
=== RUN   TestAccCodeBuildProject_sourceVersion
=== PAUSE TestAccCodeBuildProject_sourceVersion
=== RUN   TestAccCodeBuildProject_encryptionKey
=== PAUSE TestAccCodeBuildProject_encryptionKey
=== RUN   TestAccCodeBuildProject_Environment_environmentVariable
=== PAUSE TestAccCodeBuildProject_Environment_environmentVariable
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== RUN   TestAccCodeBuildProject_Environment_certificate
=== PAUSE TestAccCodeBuildProject_Environment_certificate
=== RUN   TestAccCodeBuildProject_Logs_cloudWatchLogs
=== PAUSE TestAccCodeBuildProject_Logs_cloudWatchLogs
=== RUN   TestAccCodeBuildProject_Logs_s3Logs
=== PAUSE TestAccCodeBuildProject_Logs_s3Logs
=== RUN   TestAccCodeBuildProject_buildBatch
=== PAUSE TestAccCodeBuildProject_buildBatch
=== RUN   TestAccCodeBuildProject_Source_gitCloneDepth
=== PAUSE TestAccCodeBuildProject_Source_gitCloneDepth
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesVersions
=== PAUSE TestAccCodeBuildProject_SecondarySourcesVersions
=== RUN   TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_Source_insecureSSL
=== PAUSE TestAccCodeBuildProject_Source_insecureSSL
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceType_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceType_bitbucket
=== RUN   TestAccCodeBuildProject_SourceType_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceType_codeCommit
=== RUN   TestAccCodeBuildProject_SourceType_codePipeline
=== PAUSE TestAccCodeBuildProject_SourceType_codePipeline
=== RUN   TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceType_s3
=== PAUSE TestAccCodeBuildProject_SourceType_s3
=== RUN   TestAccCodeBuildProject_SourceType_noSource
=== PAUSE TestAccCodeBuildProject_SourceType_noSource
=== RUN   TestAccCodeBuildProject_SourceType_noSourceInvalid
=== PAUSE TestAccCodeBuildProject_SourceType_noSourceInvalid
=== RUN   TestAccCodeBuildProject_tags
=== PAUSE TestAccCodeBuildProject_tags
=== RUN   TestAccCodeBuildProject_vpc
=== PAUSE TestAccCodeBuildProject_vpc
=== RUN   TestAccCodeBuildProject_windowsServer2019Container
=== PAUSE TestAccCodeBuildProject_windowsServer2019Container
=== RUN   TestAccCodeBuildProject_armContainer
=== PAUSE TestAccCodeBuildProject_armContainer
=== RUN   TestAccCodeBuildProject_linuxLambdaContainer
=== PAUSE TestAccCodeBuildProject_linuxLambdaContainer
=== RUN   TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_Artifacts_location
=== PAUSE TestAccCodeBuildProject_Artifacts_location
=== RUN   TestAccCodeBuildProject_Artifacts_name
=== PAUSE TestAccCodeBuildProject_Artifacts_name
=== RUN   TestAccCodeBuildProject_Artifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_Artifacts_namespaceType
=== RUN   TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_Artifacts_packaging
=== PAUSE TestAccCodeBuildProject_Artifacts_packaging
=== RUN   TestAccCodeBuildProject_Artifacts_path
=== PAUSE TestAccCodeBuildProject_Artifacts_path
=== RUN   TestAccCodeBuildProject_Artifacts_type
=== PAUSE TestAccCodeBuildProject_Artifacts_type
=== RUN   TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== PAUSE TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== RUN   TestAccCodeBuildProject_secondaryArtifacts
=== PAUSE TestAccCodeBuildProject_secondaryArtifacts
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_location
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_location
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_name
    acctest.go:90: Currently no solution to allow updates on name attribute
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_name (0.00s)
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_path
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_path
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_type
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_type
=== RUN   TestAccCodeBuildProject_SecondarySources_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySources_codeCommit
=== RUN   TestAccCodeBuildProject_concurrentBuildLimit
=== PAUSE TestAccCodeBuildProject_concurrentBuildLimit
=== RUN   TestAccCodeBuildProject_Environment_registryCredential
=== PAUSE TestAccCodeBuildProject_Environment_registryCredential
=== RUN   TestAccCodeBuildProject_disappears
=== PAUSE TestAccCodeBuildProject_disappears
=== CONT  TestAccCodeBuildProject_basic
=== CONT  TestAccCodeBuildProject_SourceType_gitHubEnterprise
--- PASS: TestAccCodeBuildProject_SourceType_gitHubEnterprise (31.48s)
=== CONT  TestAccCodeBuildProject_Source_gitCloneDepth
--- PASS: TestAccCodeBuildProject_basic (31.76s)
=== CONT  TestAccCodeBuildProject_SourceType_codePipeline
--- PASS: TestAccCodeBuildProject_SourceType_codePipeline (29.63s)
=== CONT  TestAccCodeBuildProject_SourceType_codeCommit
--- PASS: TestAccCodeBuildProject_Source_gitCloneDepth (41.92s)
=== CONT  TestAccCodeBuildProject_SourceType_bitbucket
--- PASS: TestAccCodeBuildProject_SourceType_codeCommit (27.99s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
--- PASS: TestAccCodeBuildProject_SourceType_bitbucket (28.64s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise (41.02s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_gitHub (40.42s)
=== CONT  TestAccCodeBuildProject_Source_insecureSSL
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket (40.48s)
=== CONT  TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
--- PASS: TestAccCodeBuildProject_Source_insecureSSL (40.24s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesVersions
--- PASS: TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise (28.11s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== NAME  TestAccCodeBuildProject_SecondarySourcesVersions
    project_test.go:1073: Step 2/5 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"secondary_sources.0.git_clone_depth":     "0",
        + 	"secondary_sources.0.insecure_ssl":        "false",
        + 	"secondary_sources.0.report_build_status": "false",
        + 	"secondary_sources.1.git_clone_depth":     "0",
        + 	"secondary_sources.1.insecure_ssl":        "false",
        + 	"secondary_sources.1.report_build_status": "false",
          }
--- FAIL: TestAccCodeBuildProject_SecondarySourcesVersions (28.41s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== NAME  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
    project_test.go:1040: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"secondary_sources.0.git_clone_depth":     "0",
        + 	"secondary_sources.0.insecure_ssl":        "false",
        + 	"secondary_sources.0.report_build_status": "false",
        + 	"secondary_sources.1.git_clone_depth":     "0",
        + 	"secondary_sources.1.insecure_ssl":        "false",
        + 	"secondary_sources.1.report_build_status": "false",
          }
--- FAIL: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise (29.74s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== NAME  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
    project_test.go:1007: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"secondary_sources.0.git_clone_depth":     "0",
        + 	"secondary_sources.0.insecure_ssl":        "false",
        + 	"secondary_sources.0.report_build_status": "false",
        + 	"secondary_sources.1.git_clone_depth":     "0",
        + 	"secondary_sources.1.insecure_ssl":        "false",
        + 	"secondary_sources.1.report_build_status": "false",
          }
--- FAIL: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub (39.87s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== NAME  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
    project_test.go:945: Step 2/4 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"secondary_sources.0.git_clone_depth":     "0",
        + 	"secondary_sources.0.insecure_ssl":        "false",
        + 	"secondary_sources.0.report_build_status": "false",
        + 	"secondary_sources.1.git_clone_depth":     "0",
        + 	"secondary_sources.1.insecure_ssl":        "false",
        + 	"secondary_sources.1.report_build_status": "false",
          }
--- FAIL: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit (57.70s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHub
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise (103.47s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_gitHub (108.93s)
=== CONT  TestAccCodeBuildProject_encryptionKey
--- PASS: TestAccCodeBuildProject_encryptionKey (64.04s)
=== CONT  TestAccCodeBuildProject_buildBatch
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_codeCommit (105.17s)
=== CONT  TestAccCodeBuildProject_Logs_s3Logs
--- PASS: TestAccCodeBuildProject_buildBatch (99.70s)
=== CONT  TestAccCodeBuildProject_Logs_cloudWatchLogs
--- PASS: TestAccCodeBuildProject_Logs_s3Logs (131.32s)
=== CONT  TestAccCodeBuildProject_Environment_certificate
--- PASS: TestAccCodeBuildProject_Logs_cloudWatchLogs (94.97s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
--- PASS: TestAccCodeBuildProject_Environment_certificate (66.21s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type (99.37s)
=== CONT  TestAccCodeBuildProject_Environment_environmentVariable
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value (114.46s)
=== CONT  TestAccCodeBuildProject_Artifacts_path
--- PASS: TestAccCodeBuildProject_Artifacts_path (62.93s)
=== CONT  TestAccCodeBuildProject_disappears
--- PASS: TestAccCodeBuildProject_Environment_environmentVariable (99.54s)
=== CONT  TestAccCodeBuildProject_Environment_registryCredential
--- PASS: TestAccCodeBuildProject_disappears (66.51s)
=== CONT  TestAccCodeBuildProject_concurrentBuildLimit
--- PASS: TestAccCodeBuildProject_Environment_registryCredential (120.20s)
=== CONT  TestAccCodeBuildProject_SecondarySources_codeCommit
--- PASS: TestAccCodeBuildProject_concurrentBuildLimit (97.45s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_type
=== NAME  TestAccCodeBuildProject_SecondarySources_codeCommit
    project_test.go:2514: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"secondary_sources.0.git_clone_depth":     "0",
        + 	"secondary_sources.0.insecure_ssl":        "false",
        + 	"secondary_sources.0.report_build_status": "false",
        + 	"secondary_sources.1.git_clone_depth":     "0",
        + 	"secondary_sources.1.insecure_ssl":        "false",
        + 	"secondary_sources.1.report_build_status": "false",
          }
--- FAIL: TestAccCodeBuildProject_SecondarySources_codeCommit (45.60s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_path
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_type
    project_test.go:2483: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-3658922322392350475",
          }
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_type (48.62s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_path
    project_test.go:2442: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-3507711775087816993",
          }
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_path (48.11s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_packaging
    project_test.go:2398: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-3651344334200491429",
          }
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_packaging (47.81s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_location
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
    project_test.go:2357: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-7340658943677557558",
          }
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_namespaceType (46.84s)
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_location
    project_test.go:2269: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-3669067451551535007",
          }
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_location (47.45s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
    project_test.go:2227: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-7328166512516173797",
          }
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled (48.10s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
    project_test.go:2186: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-4821793347480654843",
          }
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName (46.99s)
=== CONT  TestAccCodeBuildProject_secondaryArtifacts
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
    project_test.go:2145: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-8196757310541835505",
          }
--- FAIL: TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier (47.25s)
=== CONT  TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== NAME  TestAccCodeBuildProject_secondaryArtifacts
    project_test.go:2107: Step 2/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"secondary_artifacts.0.name": "",
        + 	"secondary_artifacts.0.name": "tf-acc-test-7265146717584801496",
        - 	"secondary_artifacts.1.name": "",
        + 	"secondary_artifacts.1.name": "tf-acc-test-7265146717584801496",
          }
--- FAIL: TestAccCodeBuildProject_secondaryArtifacts (49.78s)
=== CONT  TestAccCodeBuildProject_Artifacts_type
--- PASS: TestAccCodeBuildProject_Artifacts_bucketOwnerAccess (87.75s)
=== CONT  TestAccCodeBuildProject_linuxLambdaContainer
--- PASS: TestAccCodeBuildProject_Artifacts_type (88.46s)
=== CONT  TestAccCodeBuildProject_Artifacts_packaging
--- PASS: TestAccCodeBuildProject_linuxLambdaContainer (53.88s)
=== CONT  TestAccCodeBuildProject_Artifacts_overrideArtifactName
--- PASS: TestAccCodeBuildProject_Artifacts_packaging (74.48s)
=== CONT  TestAccCodeBuildProject_Artifacts_namespaceType
--- PASS: TestAccCodeBuildProject_Artifacts_overrideArtifactName (71.91s)
=== CONT  TestAccCodeBuildProject_Artifacts_name
--- PASS: TestAccCodeBuildProject_Artifacts_namespaceType (71.27s)
=== CONT  TestAccCodeBuildProject_Artifacts_location
--- PASS: TestAccCodeBuildProject_Artifacts_name (70.68s)
=== CONT  TestAccCodeBuildProject_Artifacts_encryptionDisabled
--- PASS: TestAccCodeBuildProject_Artifacts_location (79.13s)
=== CONT  TestAccCodeBuildProject_Artifacts_artifactIdentifier
--- PASS: TestAccCodeBuildProject_Artifacts_encryptionDisabled (74.09s)
=== CONT  TestAccCodeBuildProject_cache
--- PASS: TestAccCodeBuildProject_Artifacts_artifactIdentifier (63.16s)
=== CONT  TestAccCodeBuildProject_sourceVersion
--- PASS: TestAccCodeBuildProject_sourceVersion (25.46s)
=== CONT  TestAccCodeBuildProject_fileSystemLocations
--- PASS: TestAccCodeBuildProject_cache (134.72s)
=== CONT  TestAccCodeBuildProject_description
--- PASS: TestAccCodeBuildProject_description (46.02s)
=== CONT  TestAccCodeBuildProject_tags
--- PASS: TestAccCodeBuildProject_tags (41.82s)
=== CONT  TestAccCodeBuildProject_armContainer
--- PASS: TestAccCodeBuildProject_fileSystemLocations (173.78s)
=== CONT  TestAccCodeBuildProject_windowsServer2019Container
--- PASS: TestAccCodeBuildProject_armContainer (30.43s)
=== CONT  TestAccCodeBuildProject_vpc
--- PASS: TestAccCodeBuildProject_windowsServer2019Container (31.33s)
=== CONT  TestAccCodeBuildProject_buildTimeout
--- PASS: TestAccCodeBuildProject_buildTimeout (44.47s)
=== CONT  TestAccCodeBuildProject_queuedTimeout
--- PASS: TestAccCodeBuildProject_vpc (65.27s)
=== CONT  TestAccCodeBuildProject_SourceType_noSource
--- PASS: TestAccCodeBuildProject_SourceType_noSource (29.57s)
=== CONT  TestAccCodeBuildProject_SourceType_noSourceInvalid
--- PASS: TestAccCodeBuildProject_queuedTimeout (42.54s)
=== CONT  TestAccCodeBuildProject_SourceType_s3
--- PASS: TestAccCodeBuildProject_SourceType_noSourceInvalid (13.75s)
=== CONT  TestAccCodeBuildProject_badgeEnabled
--- PASS: TestAccCodeBuildProject_badgeEnabled (29.51s)
=== CONT  TestAccCodeBuildProject_publicVisibility
--- PASS: TestAccCodeBuildProject_SourceType_s3 (47.07s)
--- PASS: TestAccCodeBuildProject_publicVisibility (52.66s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	2020.058s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change: #35108.

ewbankkit · 2024-01-02T14:52:45Z

@shblue21 Thanks for the contribution 🎉 👏.

github-actions · 2024-01-12T12:44:36Z

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-02-13T02:04:06Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. labels Dec 22, 2023

terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 22, 2023

fix: queued_timeout attribute not support when enviroment is Lambda

a270b4d

shblue21 force-pushed the b-codebuild_lambda_queued_timeout branch from fc38072 to a270b4d Compare December 22, 2023 12:22

shblue21 changed the title ~~fix queued_timeout attribute not support when enviroment is Lambda~~ fix codebuild queued_timeout attribute not support when enviroment is Lambda Dec 24, 2023

shblue21 added 2 commits December 24, 2023 23:58

fix: build_timeout attribute not support when compute environment i…

44a5596

…s Lambda

feat: add tests for lambda compute type

ee5ad4a

github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 24, 2023

shblue21 changed the title ~~fix codebuild queued_timeout attribute not support when enviroment is Lambda~~ Fix unsupported properties for lambda compute types in codebuild. Dec 24, 2023

docs: addcompute_type Lambda type

844c714

ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 2, 2024

Add CHANGELOG entry.

06db5e6

ewbankkit approved these changes Jan 2, 2024

View reviewed changes

ewbankkit merged commit 853904e into hashicorp:main Jan 2, 2024
43 checks passed

github-actions bot added this to the v5.32.0 milestone Jan 2, 2024

github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix unsupported properties for lambda compute types in `codebuild`. #35043

Fix unsupported properties for lambda compute types in `codebuild`. #35043

shblue21 commented Dec 22, 2023 •

edited

Loading

github-actions bot commented Dec 22, 2023

ewbankkit left a comment •

edited

Loading

ewbankkit commented Jan 2, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Feb 13, 2024

Fix unsupported properties for lambda compute types in codebuild. #35043

Fix unsupported properties for lambda compute types in codebuild. #35043

Conversation

shblue21 commented Dec 22, 2023 • edited Loading

Description

Relations

References

Why doesn't the Lambda runtime have a build_timeout, queued_timeout?

Output from Acceptance Testing

github-actions bot commented Dec 22, 2023

Community Note

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

ewbankkit commented Jan 2, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Feb 13, 2024

Fix unsupported properties for lambda compute types in `codebuild`. #35043

Fix unsupported properties for lambda compute types in `codebuild`. #35043

shblue21 commented Dec 22, 2023 •

edited

Loading

Why doesn't the Lambda runtime have a `build_timeout`, `queued_timeout`?

ewbankkit left a comment •

edited

Loading