Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_bucket_public_access_block: Migrate to AWS SDK for Go v2 #34534

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 22, 2023

Description

Migrates the aws_s3_bucket_public_access_block resource to AWS SDK for Go v2.

Relations

Relates #33654.
Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3BucketPublicAccessBlock_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketPublicAccessBlock_ -timeout 360m
=== RUN   TestAccS3BucketPublicAccessBlock_basic
=== PAUSE TestAccS3BucketPublicAccessBlock_basic
=== RUN   TestAccS3BucketPublicAccessBlock_disappears
=== PAUSE TestAccS3BucketPublicAccessBlock_disappears
=== RUN   TestAccS3BucketPublicAccessBlock_Disappears_bucket
=== PAUSE TestAccS3BucketPublicAccessBlock_Disappears_bucket
=== RUN   TestAccS3BucketPublicAccessBlock_blockPublicACLs
=== PAUSE TestAccS3BucketPublicAccessBlock_blockPublicACLs
=== RUN   TestAccS3BucketPublicAccessBlock_blockPublicPolicy
=== PAUSE TestAccS3BucketPublicAccessBlock_blockPublicPolicy
=== RUN   TestAccS3BucketPublicAccessBlock_ignorePublicACLs
=== PAUSE TestAccS3BucketPublicAccessBlock_ignorePublicACLs
=== RUN   TestAccS3BucketPublicAccessBlock_restrictPublicBuckets
=== PAUSE TestAccS3BucketPublicAccessBlock_restrictPublicBuckets
=== CONT  TestAccS3BucketPublicAccessBlock_basic
=== CONT  TestAccS3BucketPublicAccessBlock_blockPublicPolicy
--- PASS: TestAccS3BucketPublicAccessBlock_basic (84.18s)
=== CONT  TestAccS3BucketPublicAccessBlock_restrictPublicBuckets
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (160.01s)
=== CONT  TestAccS3BucketPublicAccessBlock_ignorePublicACLs
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (150.94s)
=== CONT  TestAccS3BucketPublicAccessBlock_Disappears_bucket
--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (51.08s)
=== CONT  TestAccS3BucketPublicAccessBlock_blockPublicACLs
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (144.94s)
=== CONT  TestAccS3BucketPublicAccessBlock_disappears
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (28.44s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (91.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	393.673s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. labels Nov 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 22, 2023
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 22, 2023
@ewbankkit ewbankkit merged commit 811cc85 into main Nov 22, 2023
78 checks passed
@ewbankkit ewbankkit deleted the td-aws_s3_bucket_public_access_block-aws-sdk-go-v2 branch November 22, 2023 22:42
@github-actions github-actions bot added this to the v5.27.0 milestone Nov 22, 2023
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Copy link

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants