-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F verifiedaccess endpoint #34156
F verifiedaccess endpoint #34156
Conversation
Community NoteVoting for Prioritization
For Submitters
|
% make testacc TESTARGS='-run=TestAccEC2VerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2VerifiedAccessEndpoint_ -timeout 360m === RUN TestAccEC2VerifiedAccessEndpoint_basic === PAUSE TestAccEC2VerifiedAccessEndpoint_basic === RUN TestAccEC2VerifiedAccessEndpoint_disappears === PAUSE TestAccEC2VerifiedAccessEndpoint_disappears === CONT TestAccEC2VerifiedAccessEndpoint_basic === CONT TestAccEC2VerifiedAccessEndpoint_disappears --- PASS: TestAccEC2VerifiedAccessEndpoint_disappears (1408.01s) --- PASS: TestAccEC2VerifiedAccessEndpoint_basic (1470.22s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1484.543s
Acceptance tests so far: % make testacc TESTARGS='-run=TestAccEC2VerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2VerifiedAccessEndpoint_ -timeout 360m
=== RUN TestAccEC2VerifiedAccessEndpoint_basic
=== PAUSE TestAccEC2VerifiedAccessEndpoint_basic
=== RUN TestAccEC2VerifiedAccessEndpoint_disappears
=== PAUSE TestAccEC2VerifiedAccessEndpoint_disappears
=== CONT TestAccEC2VerifiedAccessEndpoint_basic
=== CONT TestAccEC2VerifiedAccessEndpoint_disappears
--- PASS: TestAccEC2VerifiedAccessEndpoint_disappears (1408.01s)
--- PASS: TestAccEC2VerifiedAccessEndpoint_basic (1470.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1484.543s |
make testacc TESTARGS='-run=TestAccEC2VerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=3 --- PASS: TestAccEC2VerifiedAccessEndpoint_disappears (1256.95s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccVerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVerifiedAccessEndpoint_ -timeout 720m
=== RUN TestAccVerifiedAccessEndpoint_basic
=== PAUSE TestAccVerifiedAccessEndpoint_basic
=== RUN TestAccVerifiedAccessEndpoint_networkInterface
=== PAUSE TestAccVerifiedAccessEndpoint_networkInterface
=== RUN TestAccVerifiedAccessEndpoint_tags
=== PAUSE TestAccVerifiedAccessEndpoint_tags
=== RUN TestAccVerifiedAccessEndpoint_disappears
=== PAUSE TestAccVerifiedAccessEndpoint_disappears
=== CONT TestAccVerifiedAccessEndpoint_basic
=== CONT TestAccVerifiedAccessEndpoint_tags
--- PASS: TestAccVerifiedAccessEndpoint_tags (1143.93s)
=== CONT TestAccVerifiedAccessEndpoint_networkInterface
--- PASS: TestAccVerifiedAccessEndpoint_basic (1361.01s)
=== CONT TestAccVerifiedAccessEndpoint_disappears
--- PASS: TestAccVerifiedAccessEndpoint_networkInterface (1059.30s)
--- PASS: TestAccVerifiedAccessEndpoint_disappears (1387.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 2753.739s
@markoskandylis Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for VerrifiedAccess Endpoint
Relations
Relates #29689.
References
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_VerifiedAccessEndpoint.html
Output from Acceptance Testing